content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java - Issue 2179563003: Android: Remove ContentViewCore::GetLayer() from public interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java

Issue 2179563003: Android: Remove ContentViewCore::GetLayer() from public interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | content/public/browser/android/content_view_core.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java

index a9f0f54a489b682638bab1f4462b3a50279f84e5..77211351fab7e2da8043bee0dc454cdc914814e5 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java

@@ -14,6 +14,7 @@ import android.widget.FrameLayout;

import org.chromium.base.annotations.CalledByNative;

import org.chromium.base.annotations.JNINamespace;

+import org.chromium.content_public.browser.WebContents;

import org.chromium.ui.base.WindowAndroid;

/***

@@ -128,10 +129,10 @@ public class ContentViewRenderView extends FrameLayout {

if (mContentViewCore != null) {

mContentViewCore.onPhysicalBackingSizeChanged(getWidth(), getHeight());

- nativeSetCurrentContentViewCore(mNativeContentViewRenderView,

- mContentViewCore.getNativeContentViewCore());

+ nativeSetCurrentWebContents(

+ mNativeContentViewRenderView, mContentViewCore.getWebContents());

} else {

- nativeSetCurrentContentViewCore(mNativeContentViewRenderView, 0);

+ nativeSetCurrentWebContents(mNativeContentViewRenderView, null);

}

@@ -182,8 +183,8 @@ public class ContentViewRenderView extends FrameLayout {

private native long nativeInit(long rootWindowNativePointer);

private native void nativeDestroy(long nativeContentViewRenderView);

- private native void nativeSetCurrentContentViewCore(long nativeContentViewRenderView,

- long nativeContentViewCore);

+ private native void nativeSetCurrentWebContents(

+ long nativeContentViewRenderView, WebContents webContents);

private native void nativeSurfaceCreated(long nativeContentViewRenderView);

private native void nativeSurfaceDestroyed(long nativeContentViewRenderView);

private native void nativeSurfaceChanged(long nativeContentViewRenderView,