Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2179303005: [Interpreter] Move SharedFunctionInfo creation to finalization step. (Closed)

Created:
4 years, 4 months ago by rmcilroy
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Move SharedFunctionInfo creation to finalization step. Moves the creation of SharedFunctionInfo for function literals to the finalization step. This is required for bytecode generation to be performed off-thread. BUG=v8:5203 Committed: https://crrev.com/437cf79455ac98a1ffd3ee06cce6cc1943c91dd9 Cr-Commit-Position: refs/heads/master@{#38309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -46 lines) Patch
M src/interpreter/bytecode-array-builder.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 8 chunks +66 lines, -32 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
rmcilroy
Michi, Mythri, PTAL, thanks.
4 years, 4 months ago (2016-07-27 10:25:28 UTC) #2
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-07-27 12:03:51 UTC) #7
mythria
lgtm. Thanks, Mythri
4 years, 4 months ago (2016-07-27 13:04:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179303005/1
4 years, 4 months ago (2016-08-03 16:15:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 16:41:45 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 16:43:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/437cf79455ac98a1ffd3ee06cce6cc1943c91dd9
Cr-Commit-Position: refs/heads/master@{#38309}

Powered by Google App Engine
This is Rietveld 408576698