Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1508)

Unified Diff: test/unittests/interpreter/bytecode-array-builder-unittest.cc

Issue 2179303005: [Interpreter] Move SharedFunctionInfo creation to finalization step. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-generator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/interpreter/bytecode-array-builder-unittest.cc
diff --git a/test/unittests/interpreter/bytecode-array-builder-unittest.cc b/test/unittests/interpreter/bytecode-array-builder-unittest.cc
index f83ede0e5b817c4961ff88f31bddffc1b4524319..398d3bed628340eca59aa60cf54d58b295f6be5c 100644
--- a/test/unittests/interpreter/bytecode-array-builder-unittest.cc
+++ b/test/unittests/interpreter/bytecode-array-builder-unittest.cc
@@ -99,10 +99,7 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {
.StoreLookupSlot(name, LanguageMode::STRICT);
// Emit closure operations.
- Handle<SharedFunctionInfo> shared_info = factory->NewSharedFunctionInfo(
- factory->NewStringFromStaticChars("function_a"), MaybeHandle<Code>(),
- false);
- builder.CreateClosure(shared_info, NOT_TENURED);
+ builder.CreateClosure(0, NOT_TENURED);
// Emit literal creation operations.
builder.CreateRegExpLiteral(factory->NewStringFromStaticChars("a"), 0, 0)
@@ -322,10 +319,7 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {
.StoreAccumulatorInRegister(reg);
// CreateClosureWide
- Handle<SharedFunctionInfo> shared_info2 = factory->NewSharedFunctionInfo(
- factory->NewStringFromStaticChars("function_b"), MaybeHandle<Code>(),
- false);
- builder.CreateClosure(shared_info2, NOT_TENURED);
+ builder.CreateClosure(1000, NOT_TENURED);
// Emit wide variant of literal creation operations.
builder.CreateRegExpLiteral(factory->NewStringFromStaticChars("wide_literal"),
« no previous file with comments | « src/interpreter/bytecode-generator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698