Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: gni/v8.gni

Issue 2179303003: [gn] Don't use PIE for host executables Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gni/v8.gni
diff --git a/gni/v8.gni b/gni/v8.gni
index 7ff7f6fb89ac3634a2c7ff64030805582d8c8fb9..67dc5a3b3a6d3dd453ef138205e0ea5ae1d57020 100644
--- a/gni/v8.gni
+++ b/gni/v8.gni
@@ -87,13 +87,19 @@ template("v8_source_set") {
template("v8_executable") {
executable(target_name) {
- forward_variables_from(invoker, "*", [ "configs" ])
+ forward_variables_from(invoker, "*", [ "configs", "want_pie"])
configs += invoker.configs
configs -= v8_remove_configs
configs += v8_add_configs
- if (is_linux) {
- # For enabling ASLR.
- ldflags = [ "-pie" ]
+ if (!defined(invoker.want_pie) || invoker.want_pie) {
+ if (is_linux) {
+ # For enabling ASLR.
+ ldflags = [ "-pie" ]
+ }
+ } else {
+ if (is_android) {
+ configs -= [ "//build/config/android:executable_config" ]
Michael Achenbach 2016/07/27 13:15:59 This is the only change in patch 3
+ }
}
}
}
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698