Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: BUILD.gn

Issue 2179303003: [gn] Don't use PIE for host executables Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gni/v8.gni » ('j') | gni/v8.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index c424c4f9984d51942b17f461f36ba9302709a85e..0864390755a4178b22c6ce60a645aa004fd7c25e 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -2181,6 +2181,9 @@ if (current_toolchain == v8_snapshot_toolchain) {
v8_executable("mksnapshot") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
+ # This is executed on the host only and doesn't require PIE.
+ want_pie = false
+
sources = [
"src/snapshot/mksnapshot.cc",
]
@@ -2203,6 +2206,9 @@ v8_executable("mkpeephole") {
# bytecodes that are described in bytecodes.{cc,h}.
visibility = [ ":*" ] # Only targets in this file can depend on this.
+ # This is executed on the host only and doesn't require PIE.
+ want_pie = false
+
sources = [
"src/interpreter/bytecode-peephole-optimizer.h",
"src/interpreter/bytecodes.cc",
« no previous file with comments | « no previous file | gni/v8.gni » ('j') | gni/v8.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698