Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: chrome/browser/ui/avatar_button_error_controller_delegate.h

Issue 2179283002: Refactored signin/sync error controllers for the avatar button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pure virtual interface Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/avatar_button_error_controller_delegate.h
diff --git a/chrome/browser/ui/avatar_button_error_controller_delegate.h b/chrome/browser/ui/avatar_button_error_controller_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..9e9ddd21659b87b2b516152df7938ba63e53557d
--- /dev/null
+++ b/chrome/browser/ui/avatar_button_error_controller_delegate.h
@@ -0,0 +1,17 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_AVATAR_BUTTON_ERROR_CONTROLLER_DELEGATE_H_
+#define CHROME_BROWSER_UI_AVATAR_BUTTON_ERROR_CONTROLLER_DELEGATE_H_
+
+// Delegate that allows AvatarButtonErrorController to communicate to
+// NewAvatarButton.
+class AvatarButtonErrorControllerDelegate {
+ public:
+ // Called when the signin/sync errors that should be exposed in the avatar
+ // button change.
+ virtual void OnAvatarErrorChanged() = 0;
+};
sky 2016/08/01 22:59:40 Add a virtual destructor in the protected section
Jane 2016/08/02 14:23:18 Done. Is it ok to inline it here? Couldn't think o
sky 2016/08/02 19:34:40 Yes. We generally inline destructor for pure virtu
+
+#endif // CHROME_BROWSER_UI_AVATAR_BUTTON_ERROR_CONTROLLER_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698