chrome/browser/ui/avatar_button_error_controller_delegate.h - Issue 2179283002: Refactored signin/sync error controllers for the avatar button

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/avatar_button_error_controller_delegate.h

Issue 2179283002: Refactored signin/sync error controllers for the avatar button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pure virtual interface Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/avatar_button_error_controller.cc ('K') | « chrome/browser/ui/avatar_button_error_controller.cc ('k') | chrome/browser/ui/views/profiles/new_avatar_button.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_AVATAR_BUTTON_ERROR_CONTROLLER_DELEGATE_H_

	6 #define CHROME_BROWSER_UI_AVATAR_BUTTON_ERROR_CONTROLLER_DELEGATE_H_

	7

	8 // Delegate that allows AvatarButtonErrorController to communicate to

	9 // NewAvatarButton.

	10 class AvatarButtonErrorControllerDelegate {

	11 public:

	12 // Called when the signin/sync errors that should be exposed in the avatar

	13 // button change.

	14 virtual void OnAvatarErrorChanged() = 0;

	15 };
	sky 2016/08/01 22:59:40 Add a virtual destructor in the protected section Add a virtual destructor in the protected section to make it clear the controller doesn't own the delegate. Jane 2016/08/02 14:23:18 Done. Is it ok to inline it here? Couldn't think o Show quoted text On 2016/08/01 22:59:40, sky wrote: > Add a virtual destructor in the protected section to make it clear the > controller doesn't own the delegate. Done. Is it ok to inline it here? Couldn't think of another way. sky 2016/08/02 19:34:40 Yes. We generally inline destructor for pure virtu Show quoted text On 2016/08/02 14:23:18, Jane wrote: > On 2016/08/01 22:59:40, sky wrote: > > Add a virtual destructor in the protected section to make it clear the > > controller doesn't own the delegate. > > Done. Is it ok to inline it here? Couldn't think of another way. Yes. We generally inline destructor for pure virtual classes.
	16

	17 #endif // CHROME_BROWSER_UI_AVATAR_BUTTON_ERROR_CONTROLLER_DELEGATE_H_

OLD	NEW