Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: components/arc/test/fake_app_instance.cc

Issue 2179273002: Mojo C++ bindings: support mapping T and T? differently. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/arc/test/fake_app_instance.h ('k') | device/bluetooth/public/interfaces/bluetooth_uuid.typemap » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/test/fake_app_instance.cc
diff --git a/components/arc/test/fake_app_instance.cc b/components/arc/test/fake_app_instance.cc
index 64822b753a92bead33f4e07fe6eb441e5bb39514..8e734a6fb06d76905fc88b928efeb993e634d8ca 100644
--- a/components/arc/test/fake_app_instance.cc
+++ b/components/arc/test/fake_app_instance.cc
@@ -47,7 +47,7 @@ void FakeAppInstance::RefreshAppList() {
void FakeAppInstance::LaunchApp(const mojo::String& package_name,
const mojo::String& activity,
- const gfx::Rect& dimension) {
+ const base::Optional<gfx::Rect>& dimension) {
launch_requests_.push_back(new Request(package_name, activity));
}
@@ -207,8 +207,9 @@ void FakeAppInstance::SetNotificationsEnabled(const mojo::String& package_name,
void FakeAppInstance::InstallPackage(mojom::ArcPackageInfoPtr arcPackageInfo) {}
-void FakeAppInstance::LaunchIntent(const mojo::String& intent_uri,
- const gfx::Rect& dimension_on_screen) {
+void FakeAppInstance::LaunchIntent(
+ const mojo::String& intent_uri,
+ const base::Optional<gfx::Rect>& dimension_on_screen) {
launch_intents_.push_back(new mojo::String(intent_uri));
}
« no previous file with comments | « components/arc/test/fake_app_instance.h ('k') | device/bluetooth/public/interfaces/bluetooth_uuid.typemap » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698