Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: components/arc/test/fake_app_instance.h

Issue 2179273002: Mojo C++ bindings: support mapping T and T? differently. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/arc/test/fake_app_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/test/fake_app_instance.h
diff --git a/components/arc/test/fake_app_instance.h b/components/arc/test/fake_app_instance.h
index c9394ebb1b1f5a88426ad01cb8fc1f2dae910c75..8b5dcc1ffe89cf77a5576dc85fd82488f569c579 100644
--- a/components/arc/test/fake_app_instance.h
+++ b/components/arc/test/fake_app_instance.h
@@ -85,12 +85,13 @@ class FakeAppInstance : public mojom::AppInstance {
void RefreshAppList() override;
void LaunchApp(const mojo::String& package_name,
const mojo::String& activity,
- const gfx::Rect& dimension) override;
+ const base::Optional<gfx::Rect>& dimension) override;
void RequestAppIcon(const mojo::String& package_name,
const mojo::String& activity,
mojom::ScaleFactor scale_factor) override;
- void LaunchIntent(const mojo::String& intent_uri,
- const gfx::Rect& dimension_on_screen) override;
+ void LaunchIntent(
+ const mojo::String& intent_uri,
+ const base::Optional<gfx::Rect>& dimension_on_screen) override;
void RequestIcon(const mojo::String& icon_resource_id,
arc::mojom::ScaleFactor scale_factor,
const RequestIconCallback& callback) override;
« no previous file with comments | « no previous file | components/arc/test/fake_app_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698