Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2179263002: cc: Remove SetLayerPropertiesForTesting from LayerTreeHostCommonTestBase (Closed)

Created:
4 years, 5 months ago by danakj
Modified:
4 years, 4 months ago
Reviewers:
jaydasika, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO), piman, vmpstr
Base URL:
https://chromium.googlesource.com/chromium/src.git@lthcommontest-harness
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove SetLayerPropertiesForTesting from LayerTreeHostCommonTestBase Replaces all remaining uses with direct set function calls onto the Layer/LayerImpl. R=ajuma@chromium.org, jaydasika@chromium.org BUG=630754 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/f78fb2721e1983a054d169c14557cd814dcea915 Cr-Commit-Position: refs/heads/master@{#407873}

Patch Set 1 #

Patch Set 2 : lthcommontest-harness2: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+714 lines, -1626 lines) Patch
M cc/test/layer_tree_host_common_test.h View 1 1 chunk +0 lines, -38 lines 0 comments Download
M cc/test/layer_tree_host_common_test.cc View 1 1 chunk +1 line, -48 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 137 chunks +568 lines, -1154 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 1 44 chunks +145 lines, -386 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
danakj
I also deleted 1 test that has evolved until it has no EXPECT calls left.
4 years, 5 months ago (2016-07-26 01:05:34 UTC) #2
ajuma
lgtm
4 years, 4 months ago (2016-07-26 14:48:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179263002/20001
4 years, 4 months ago (2016-07-26 19:02:12 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 19:06:30 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 19:11:59 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f78fb2721e1983a054d169c14557cd814dcea915
Cr-Commit-Position: refs/heads/master@{#407873}

Powered by Google App Engine
This is Rietveld 408576698