Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2179173002: exo: Fix crash in out-of-order destruction of Gamepad (Closed)

Created:
4 years, 4 months ago by denniskempin
Modified:
4 years, 4 months ago
Reviewers:
reveman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

exo: Fix crash in out-of-order destruction of Gamepad Destroying the gaming input resource will destroy the gamepad polling thread, which causes the Gamepad destructor to access an invalid reference to the task runner of that thread. This CL changes the raw pointer to a ref counted pointer so we won't destroy the task runner prematurely. BUG=620977 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2159283002 Cr-Commit-Position: refs/heads/master@{#406327} (cherry picked from commit a3633143505b30713e83baabfa7767877bf79788)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/exo/gamepad.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
reveman
lgtm
4 years, 4 months ago (2016-07-25 21:31:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179173002/1
4 years, 4 months ago (2016-07-25 21:33:01 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 21:34:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698