exo: Fix crash in out-of-order destruction of Gamepad

exo: Fix crash in out-of-order destruction of Gamepad

Destroying the gaming input resource will destroy the gamepad
polling thread, which causes the Gamepad destructor to access an
invalid reference to the task runner of that thread.
This CL changes the raw pointer to a ref counted pointer so we won't
destroy the task runner prematurely.

BUG=620977
Committed: https://crrev.com/a3633143505b30713e83baabfa7767877bf79788
Cr-Commit-Position: refs/heads/master@{#406327}

[denniskempin, 2016-07-19 17:04:13]

denniskempin@google.com changed reviewers:
+ reveman@chromium.org

[reveman, 2016-07-19 17:16:53]

https://codereview.chromium.org/2159283002/diff/1/components/exo/gamepad.h
File components/exo/gamepad.h (right):

https://codereview.chromium.org/2159283002/diff/1/components/exo/gamepad.h#ne...
components/exo/gamepad.h:33: scoped_refptr<base::SingleThreadTaskRunner>
polling_task_runner);
This just adds ref-count churn. Passing a raw pointer as before is fine.

https://codereview.chromium.org/2159283002/diff/1/components/exo/gamepad.h#ne...
components/exo/gamepad.h:37: scoped_refptr<base::SingleThreadTaskRunner>
polling_task_runner,
ditto

[denniskempin, 2016-07-19 17:24:53]

that... actually makes this change even simpler. Done.

[reveman, 2016-07-19 17:33:14]

lgtm

[denniskempin, 2016-07-19 17:53:24]

The CQ bit was checked by denniskempin@google.com

[commit-bot: I haz the power, 2016-07-19 17:54:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 18:36:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-19 18:36:33]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 18:39:34]

Description was changed from

==========
exo: Fix crash in out-of-order destruction of Gamepad

Destroying the gaming input resource will destroy the gamepad
polling thread, which causes the Gamepad destructor to access an
invalid reference to the task runner of that thread.
This CL changes the raw pointer to a ref counted pointer so we won't
destroy the task runner prematurely.

BUG=620977
==========

to

==========
exo: Fix crash in out-of-order destruction of Gamepad

Destroying the gaming input resource will destroy the gamepad
polling thread, which causes the Gamepad destructor to access an
invalid reference to the task runner of that thread.
This CL changes the raw pointer to a ref counted pointer so we won't
destroy the task runner prematurely.

BUG=620977

Committed: https://crrev.com/a3633143505b30713e83baabfa7767877bf79788
Cr-Commit-Position: refs/heads/master@{#406327}
==========

[commit-bot: I haz the power, 2016-07-19 18:39:35]

Patchset 2 (id:??) landed as
https://crrev.com/a3633143505b30713e83baabfa7767877bf79788
Cr-Commit-Position: refs/heads/master@{#406327}