Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2179163004: Reland of Remove pageview from map immediately (Closed)

Created:
2 years, 10 months ago by dsinclair
Modified:
2 years, 10 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Reland of Remove pageview from map immediately This reverts commit f2cee9894b9f7cf2e50060965ad1eedd90ab55b6. This CL removes the default parameter from the CPDFSDK_Document::GetPageView |ReNew| flag and updates the code as needed. In CFFL_FormFillter::KillFocusForAnnot we flip the flag to |FALSE| as we don't want to re-create the page view if it is already removed. If we don't do this then the page view will be re-created in the map, the page associated to the page view, but then the page can be deleted out from under the pageview as it isn't owned by the page view. BUG=chromium:630654 Committed: https://pdfium.googlesource.com/pdfium/+/461eeafe191068ac8c32f2717907fc6a22a667d2

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : FX_BOOL to bool #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M fpdfsdk/formfiller/cffl_combobox.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fsdk_baseform.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fsdk_mgr.cpp View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Field.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
dsinclair
PTAL.
2 years, 10 months ago (2016-07-26 20:21:09 UTC) #4
Lei Zhang
lgtm - Darn, previous attempt was just too easy. - Would be nice to go ...
2 years, 10 months ago (2016-07-26 22:37:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179163004/40001
2 years, 10 months ago (2016-07-27 14:28:00 UTC) #10
commit-bot: I haz the power
2 years, 10 months ago (2016-07-27 14:40:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/461eeafe191068ac8c32f2717907fc6a22a6...

Powered by Google App Engine
This is Rietveld 408576698