fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp - Issue 2179163004: Reland of Remove pageview from map immediately

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp

Issue 2179163004: Reland of Remove pageview from map immediately (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: FX_BOOL to bool Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp

diff --git a/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp b/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp

index 42dad4557e60b0ef0eb337028a0f9d12dbe6bed3..95f0cbe25a5527c0c7c97bd6c4665d33388bdc7c 100644

--- a/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp

+++ b/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp

@@ -503,7 +503,7 @@ void CPDFXFA_Document::WidgetPostAdd(CXFA_FFWidget* hWidget,

if (!pXFAPage)

return;

- m_pSDKDoc->GetPageView(pXFAPage)->AddAnnot(hWidget);

+ m_pSDKDoc->GetPageView(pXFAPage, true)->AddAnnot(hWidget);

}

void CPDFXFA_Document::WidgetPreRemove(CXFA_FFWidget* hWidget,

@@ -519,7 +519,7 @@ void CPDFXFA_Document::WidgetPreRemove(CXFA_FFWidget* hWidget,

if (!pXFAPage)

return;

- CPDFSDK_PageView* pSdkPageView = m_pSDKDoc->GetPageView(pXFAPage);

+ CPDFSDK_PageView* pSdkPageView = m_pSDKDoc->GetPageView(pXFAPage, true);

if (CPDFSDK_Annot* pAnnot = pSdkPageView->GetAnnotByXFAWidget(hWidget))

pSdkPageView->DeleteAnnot(pAnnot);

}

« no previous file with comments | « fpdfsdk/fpdfformfill.cpp ('k') | fpdfsdk/fsdk_baseform.cpp » ('j') | no next file with comments »