Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2179113002: Mojo C++ bindings: add a presubmit check to disallow adding new mojom targets with use_new_wrapper_… (Closed)

Created:
4 years, 5 months ago by yzshen1
Modified:
4 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: add a presubmit check to disallow adding new mojom targets with use_new_wrapper_types set to false. BUG=624136 Committed: https://crrev.com/d99f726a3e3b7007c5c4dec659f78796c730611b Cr-Commit-Position: refs/heads/master@{#407595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M PRESUBMIT.py View 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yzshen1
Hi, John. Would you please take a look? Thanks!
4 years, 5 months ago (2016-07-25 18:49:39 UTC) #2
jam
lgtm
4 years, 5 months ago (2016-07-25 19:18:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179113002/1
4 years, 5 months ago (2016-07-25 20:14:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 21:44:38 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 21:46:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d99f726a3e3b7007c5c4dec659f78796c730611b
Cr-Commit-Position: refs/heads/master@{#407595}

Powered by Google App Engine
This is Rietveld 408576698