Mojo C++ bindings: add a presubmit check to disallow adding new mojom targets with use_new_wrapper_…

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into depot_tools.
 """
 
@@ skipping 1480 matching lines @@
       output = output_api.PresubmitError
     else:
       output = output_api.PresubmitPromptWarning
     results.append(output(
         'Found changes to IPC files without a security OWNER!',
         long_text='\n\n'.join(errors)))
 
   return results
 
 
+def _CheckMojoUsesNewWrapperTypes(input_api, output_api):
+  """Checks to make sure that all newly added mojom targets map array/map/string
+     to STL (for chromium) or WTF (for blink) types.
+     TODO(yzshen): remove this check once crbug.com/624136 is completed.
+  """
+  files = []
+  pattern = input_api.re.compile(r'use_new_wrapper_types.*false',
+                                 input_api.re.MULTILINE)
+
+  for f in input_api.AffectedFiles():
+    if not f.LocalPath().endswith(('.gyp', '.gypi', 'gn', 'gni')):
+      continue
+
+    for _, line in f.ChangedContents():
+      if pattern.search(line):
+        files.append(f)
+        break
+
+  if len(files):
+    return [output_api.PresubmitError(
+        'Do not introduce new mojom targets with use_new_wrapper_types set to '
+        'false. The mode is deprecated and will be removed soon.',
+        files)]
+  return []
+
+
 def _CheckAndroidToastUsage(input_api, output_api):
   """Checks that code uses org.chromium.ui.widget.Toast instead of
      android.widget.Toast (Chromium Toast doesn't force hardware
      acceleration on low-end devices, saving memory).
   """
   toast_import_pattern = input_api.re.compile(
       r'^import android\.widget\.Toast;$')
 
   errors = []
 
@@ skipping 444 matching lines @@
   results.extend(_CheckNoDeprecatedJS(input_api, output_api))
   results.extend(_CheckParseErrors(input_api, output_api))
   results.extend(_CheckForIPCRules(input_api, output_api))
   results.extend(_CheckForCopyrightedCode(input_api, output_api))
   results.extend(_CheckForWindowsLineEndings(input_api, output_api))
   results.extend(_CheckSingletonInHeaders(input_api, output_api))
   results.extend(_CheckNoDeprecatedCompiledResourcesGYP(input_api, output_api))
   results.extend(_CheckPydepsNeedsUpdating(input_api, output_api))
   results.extend(_CheckJavaStyle(input_api, output_api))
   results.extend(_CheckIpcOwners(input_api, output_api))
+  results.extend(_CheckMojoUsesNewWrapperTypes(input_api, output_api))
 
   if any('PRESUBMIT.py' == f.LocalPath() for f in input_api.AffectedFiles()):
     results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
         input_api, output_api,
         input_api.PresubmitLocalPath(),
         whitelist=[r'^PRESUBMIT_test\.py$']))
   return results
 
 
 def _CheckAuthorizedAuthor(input_api, output_api):
@@ skipping 245 matching lines @@
   results.extend(input_api.canned_checks.CheckTreeIsOpen(
       input_api,
       output_api,
       json_url='http://chromium-status.appspot.com/current?format=json'))
 
   results.extend(input_api.canned_checks.CheckChangeHasBugField(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasDescription(
       input_api, output_api))
   return results