[Mac/GN] Clean up old version folders in Chromium.app/Contents/Versions.

[Mac/GN] Clean up old version folders in Chromium.app/Contents/Versions.

This prevents the app bundle from growing a lot in between clobber builds.

R=mark@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/86e7cab0d6956e04162ad559e2a7068518f0cfae

[Robert Sesek, 2016-07-25 15:50:12]

The CQ bit was checked by rsesek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 15:50:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 16:43:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 16:43:27]

Dry run: This issue passed the CQ dry run.

[Mark Mentovai, 2016-07-25 18:13:46]

LGTM

https://codereview.chromium.org/2179013002/diff/1/chrome/tools/build/mac/clea...
File chrome/tools/build/mac/clean_up_old_versions.py (right):

https://codereview.chromium.org/2179013002/diff/1/chrome/tools/build/mac/clea...
chrome/tools/build/mac/clean_up_old_versions.py:17: open(stamp_path,
'w').close()
You should also call os.utime(stamp_path, None) to guarantee that the mtime is
updated. Python seems to touch the stamp with this one-liner, probably because
'w' maps to O_WRONLY | O_TRUNC, but I don’t think anything guarantees that
(specifically, I don’t think that a no-op ftruncate() is guaranteed to touch the
mtime).

[Robert Sesek, 2016-07-25 18:21:39]

The CQ bit was checked by rsesek@chromium.org to run a CQ dry run

[Robert Sesek, 2016-07-25 18:21:41]

https://codereview.chromium.org/2179013002/diff/1/chrome/tools/build/mac/clea...
File chrome/tools/build/mac/clean_up_old_versions.py (right):

https://codereview.chromium.org/2179013002/diff/1/chrome/tools/build/mac/clea...
chrome/tools/build/mac/clean_up_old_versions.py:17: open(stamp_path,
'w').close()
On 2016/07/25 18:13:46, Mark Mentovai wrote:
> You should also call os.utime(stamp_path, None) to guarantee that the mtime is
> updated. Python seems to touch the stamp with this one-liner, probably because
> 'w' maps to O_WRONLY | O_TRUNC, but I don’t think anything guarantees that
> (specifically, I don’t think that a no-op ftruncate() is guaranteed to touch
the
> mtime).

Done.

[commit-bot: I haz the power, 2016-07-25 18:22:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 20:03:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 20:03:15]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[commit-bot: I haz the power, 2016-07-25 20:19:36]

Description was changed from

==========
[Mac/GN] Clean up old version folders in Chromium.app/Contents/Versions.

This prevents the app bundle from growing a lot in between clobber builds.

R=mark@chromium.org
==========

to

==========
[Mac/GN] Clean up old version folders in Chromium.app/Contents/Versions.

This prevents the app bundle from growing a lot in between clobber builds.

R=mark@chromium.org

Committed: https://crrev.com/86e7cab0d6956e04162ad559e2a7068518f0cfae
Cr-Commit-Position: refs/heads/master@{#407559}
==========

[commit-bot: I haz the power, 2016-07-25 20:19:37]

Patchset 2 (id:??) landed as
https://crrev.com/86e7cab0d6956e04162ad559e2a7068518f0cfae
Cr-Commit-Position: refs/heads/master@{#407559}

[Robert Sesek, 2016-07-25 20:22:47]

Description was changed from

==========
[Mac/GN] Clean up old version folders in Chromium.app/Contents/Versions.

This prevents the app bundle from growing a lot in between clobber builds.

R=mark@chromium.org

Committed: https://crrev.com/86e7cab0d6956e04162ad559e2a7068518f0cfae
Cr-Commit-Position: refs/heads/master@{#407559}
==========

to

==========
[Mac/GN] Clean up old version folders in Chromium.app/Contents/Versions.

This prevents the app bundle from growing a lot in between clobber builds.

R=mark@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/86e7cab0d6956e04162ad559e2a7...
==========

[Robert Sesek, 2016-07-25 20:22:49]

Committed patchset #2 (id:20001) manually as
86e7cab0d6956e04162ad559e2a7068518f0cfae (presubmit successful).