Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chrome/BUILD.gn

Issue 2179013002: [Mac/GN] Clean up old version folders in Chromium.app/Contents/Versions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: os.utime Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/tools/build/mac/clean_up_old_versions.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index ee1ff08716937489da3b345289c23bbecd25ab1d..8b3ab7afb6430940a862c39fa1554cd08621a7b0 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -622,6 +622,10 @@ if (is_win) {
public_deps = [
":chrome_helper_app",
+ # Before bundling the versioned app components, delete any existing
+ # versions.
+ ":clean_up_old_versions",
+
# keystone_registration_framework copies the framework into the framework
# bundle via a script that performs additional actions, rather than
# relying on a bundle_data to copy it.
@@ -633,6 +637,18 @@ if (is_win) {
]
}
+ action("clean_up_old_versions") {
+ script = "//chrome/tools/build/mac/clean_up_old_versions.py"
+ outputs = [
+ "$root_gen_dir/run_$target_name.stamp",
+ ]
+ args = [
+ rebase_path("$root_out_dir/$chrome_product_full_name.app",
+ root_build_dir),
+ "$chrome_version_full",
+ ] + rebase_path(outputs, root_build_dir)
+ }
+
tweak_info_plist("chrome_helper_plist") {
info_plist = "app/helper-Info.plist"
args = [
« no previous file with comments | « no previous file | chrome/tools/build/mac/clean_up_old_versions.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698