content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl - Issue 2178973004: DialogSurfaceManager implementation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl

Issue 2178973004: DialogSurfaceManager implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed IDialogSurfaceActivityMapper from common.aidl Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/public/android/java/src/org/chromium/content/browser/DialogSurfaceWindowTokenProviderImpl.java ('K') | « content/public/android/java/src/org/chromium/content/browser/DialogSurfaceWindowTokenProviderImpl.java ('k') | gpu/ipc/common/BUILD.gn » ('j') | gpu/ipc/common/android/dialog_surface_lookup.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2012 The Chromium Authors. All rights reserved.	1 // Copyright 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 package org.chromium.content.common;	5 package org.chromium.content.common;

6	6

7 import org.chromium.content.common.SurfaceWrapper;	7 import org.chromium.content.common.SurfaceWrapper;

8 import android.view.Surface;	8 import android.view.Surface;

9	9

10 interface IChildProcessCallback {	10 interface IChildProcessCallback {

11	11

12 // Conduit to pass a Surface from the sandboxed renderer to the plugin.	12 // Conduit to pass a Surface from the sandboxed renderer to the plugin.

13 void establishSurfacePeer(	13 void establishSurfacePeer(

14 int pid, in Surface surface, int primaryID, int secondaryID);	14 int pid, in Surface surface, int primaryID, int secondaryID);

15	15

16 void forwardSurfaceForSurfaceRequest(	16 void forwardSurfaceForSurfaceRequest(

17 in UnguessableToken requestToken, in Surface surface);	17 in UnguessableToken requestToken, in Surface surface);

18	18

19 SurfaceWrapper getViewSurface(int surfaceId);	19 SurfaceWrapper getViewSurface(int surfaceId);

	20

	21 // Return the DialogSurfaceManager instance.

	22 IBinder getDialogSurfaceManager();
	boliu 2017/01/04 23:14:39 Manager only has a single method. Is it going to g Manager only has a single method. Is it going to get more? Maybe it should just be folded into this interface? liberato (no reviews please) 2017/01/11 22:17:56 i expect that it will get more, based on my discus Show quoted text On 2017/01/04 23:14:39, boliu wrote: > Manager only has a single method. Is it going to get more? Maybe it should just > be folded into this interface? i expect that it will get more, based on my discussions with the VR folks. it may need to be configured to talk to GVR.
20 }	23 }

OLD	NEW