Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 217893002: Revert "Don't hardcode output directory in findbugs.py" (Closed)

Created:
6 years, 9 months ago by navabi
Modified:
6 years, 8 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Revert "Don't hardcode output directory in findbugs.py" This reverts commit 42e7514f5c983268e38ff8773cd6544af081ebab. It is breaking the bots like this: https://chromegw.corp.google.com/i/clank/builders/clang-builder/builds/3819 Traceback (most recent call last): ... Exception: The BUILDTYPE environment variable has not been set The reason is that the downstream clang-builder uses recipes, and recipes don't set environment variables between steps. The recipe being used is android_builder which can be checkout as part of the buildbot code in dir: build/scripts/slave/recipes/android/. TBR=andrewhayden@google.com BUG=357190 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M build/android/buildbot/bb_host_steps.py View 2 chunks +5 lines, -4 lines 0 comments Download
M build/android/pylib/utils/findbugs.py View 6 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
navabi
6 years, 9 months ago (2014-03-28 23:25:47 UTC) #1
navabi
The CQ bit was checked by navabi@google.com
6 years, 9 months ago (2014-03-28 23:53:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/217893002/1
6 years, 9 months ago (2014-03-28 23:57:53 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 00:28:06 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 9 months ago (2014-03-29 00:28:07 UTC) #5
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 9 months ago (2014-03-29 00:35:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/217893002/1
6 years, 9 months ago (2014-03-29 00:36:17 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 01:45:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-29 01:45:28 UTC) #9
navabi
The CQ bit was checked by navabi@google.com
6 years, 8 months ago (2014-03-29 16:50:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/217893002/1
6 years, 8 months ago (2014-03-29 16:51:27 UTC) #11
navabi
The CQ bit was unchecked by navabi@google.com
6 years, 8 months ago (2014-03-29 17:39:09 UTC) #12
navabi
The CQ bit was checked by navabi@google.com
6 years, 8 months ago (2014-03-29 17:39:12 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 19:31:38 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 19:31:38 UTC) #15
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 8 months ago (2014-03-29 21:55:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/217893002/1
6 years, 8 months ago (2014-03-29 21:55:25 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 23:30:43 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 23:30:44 UTC) #19
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 8 months ago (2014-03-30 01:21:02 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/217893002/1
6 years, 8 months ago (2014-03-30 01:21:44 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-30 02:57:32 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-30 02:57:32 UTC) #23
navabi
The CQ bit was checked by navabi@google.com
6 years, 8 months ago (2014-03-30 17:13:38 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/217893002/1
6 years, 8 months ago (2014-03-30 17:13:46 UTC) #25
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 18:35:13 UTC) #26
Message was sent while issue was closed.
Change committed as 260458

Powered by Google App Engine
This is Rietveld 408576698