Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3980)

Unified Diff: build/android/buildbot/bb_host_steps.py

Issue 217893002: Revert "Don't hardcode output directory in findbugs.py" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/utils/findbugs.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_host_steps.py
diff --git a/build/android/buildbot/bb_host_steps.py b/build/android/buildbot/bb_host_steps.py
index 48d2d9a437a12cc930c1415ddf3e959e470898a5..b2bda6c9d682783c8d43aa0983edfd4ab78580ad 100755
--- a/build/android/buildbot/bb_host_steps.py
+++ b/build/android/buildbot/bb_host_steps.py
@@ -80,12 +80,14 @@ def ExtractBuild(options):
def FindBugs(options):
- _ = options # keeps the linter and findbugs happy, parameter is not used
bb_annotations.PrintNamedStep('findbugs')
- RunCmd([SrcPath('build', 'android', 'findbugs_diff.py')])
+ build_type = []
+ if options.target == 'Release':
+ build_type = ['--release-build']
+ RunCmd([SrcPath('build', 'android', 'findbugs_diff.py')] + build_type)
RunCmd([SrcPath(
'tools', 'android', 'findbugs_plugin', 'test',
- 'run_findbugs_plugin_tests.py')])
+ 'run_findbugs_plugin_tests.py')] + build_type)
def BisectPerfRegression(options):
@@ -132,7 +134,6 @@ def main(argv):
setattr(options, 'target', options.factory_properties.get('target', 'Debug'))
setattr(options, 'extra_src',
options.factory_properties.get('extra_src', ''))
- constants.SetBuildType(options.target)
if options.steps:
bb_utils.RunSteps(options.steps.split(','), GetHostStepCmds(), options)
« no previous file with comments | « no previous file | build/android/pylib/utils/findbugs.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698