Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1516)

Unified Diff: chrome/browser/installable/installable_manager.h

Issue 2178833002: Add new app banner metrics using InstallableStatusCode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@banner-integrate-checker-no-refptr
Patch Set: Fix histogram name Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/installable/installable_manager.h
diff --git a/chrome/browser/installable/installable_manager.h b/chrome/browser/installable/installable_manager.h
index 80bc3d3a77d22c0f8c0bebc63e9d2c96d4a2def4..92ac41eb5d66afa7e45beab6257fd72bae7dc22a 100644
--- a/chrome/browser/installable/installable_manager.h
+++ b/chrome/browser/installable/installable_manager.h
@@ -47,7 +47,7 @@ struct InstallableParams {
// fields will be set to null, empty, or false.
struct InstallableData {
// NO_ERROR_DETECTED if there were no issues.
- const InstallableErrorCode error_code;
+ const InstallableStatusCode error_code;
// Empty if the site has no <link rel="manifest"> tag.
const GURL& manifest_url;
@@ -121,13 +121,13 @@ class InstallableManager
// Returns the error code associated with the resources requested in |params|,
// or NO_ERROR_DETECTED if there is no error.
- InstallableErrorCode GetErrorCode(const InstallableParams& params);
+ InstallableStatusCode GetErrorCode(const InstallableParams& params);
// Gets/sets parts of particular properties. Exposed for testing.
- InstallableErrorCode manifest_error() const;
- InstallableErrorCode installable_error() const;
- void set_installable_error(InstallableErrorCode error_code);
- InstallableErrorCode icon_error(const IconParams& icon_params);
+ InstallableStatusCode manifest_error() const;
+ InstallableStatusCode installable_error() const;
+ void set_installable_error(InstallableStatusCode error_code);
+ InstallableStatusCode icon_error(const IconParams& icon_params);
GURL& icon_url(const IconParams& icon_params);
const SkBitmap* icon(const IconParams& icon);
@@ -148,7 +148,7 @@ class InstallableManager
void SetManifestDependentTasksComplete();
// Methods coordinating and dispatching work for the current task.
- void RunCallback(const Task& task, InstallableErrorCode error);
+ void RunCallback(const Task& task, InstallableStatusCode error);
void StartNextTask();
void WorkOnTask();
« no previous file with comments | « chrome/browser/installable/installable_logging.cc ('k') | chrome/browser/installable/installable_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698