Add new app banner metrics using InstallableStatusCode.

chrome/browser/installable/installable_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_INSTALLABLE_INSTALLABLE_MANAGER_H_
 #define CHROME_BROWSER_INSTALLABLE_INSTALLABLE_MANAGER_H_
 
 #include <map>
 #include <memory>
 #include <utility>
@@ skipping 29 matching lines @@
   // parameters, and that the icon can be fetched and isn't an empty bitmap.
   bool fetch_valid_icon = false;
 };
 
 // This struct is passed to an InstallableCallback when the InstallableManager
 // has finished working. Each reference is owned by InstallableManager, and
 // callers should copy any objects which they wish to use later. Non-requested
 // fields will be set to null, empty, or false.
 struct InstallableData {
   // NO_ERROR_DETECTED if there were no issues.
-  const InstallableErrorCode error_code;
+  const InstallableStatusCode error_code;
 
   // Empty if the site has no <link rel="manifest"> tag.
   const GURL& manifest_url;
 
   // Empty if the site has an unparseable manifest.
   const content::Manifest& manifest;
 
   // Empty if no icon was requested.
   const GURL& icon_url;
 
@@ skipping 53 matching lines @@
 
   // Returns true if the icon sizes in |params| matches any fetched icon. false
   // if no icon has been requested yet or there is no match.
   bool IsIconFetched(const InstallableParams& params) const;
 
   // Sets the icon parameters in |params| as being fetched.
   void SetIconFetched(const InstallableParams& params);
 
   // Returns the error code associated with the resources requested in |params|,
   // or NO_ERROR_DETECTED if there is no error.
-  InstallableErrorCode GetErrorCode(const InstallableParams& params);
+  InstallableStatusCode GetErrorCode(const InstallableParams& params);
 
   // Gets/sets parts of particular properties. Exposed for testing.
-  InstallableErrorCode manifest_error() const;
-  InstallableErrorCode installable_error() const;
-  void set_installable_error(InstallableErrorCode error_code);
-  InstallableErrorCode icon_error(const IconParams& icon_params);
+  InstallableStatusCode manifest_error() const;
+  InstallableStatusCode installable_error() const;
+  void set_installable_error(InstallableStatusCode error_code);
+  InstallableStatusCode icon_error(const IconParams& icon_params);
   GURL& icon_url(const IconParams& icon_params);
   const SkBitmap* icon(const IconParams& icon);
 
   // Returns the WebContents to which this object is attached, or nullptr if the
   // WebContents doesn't exist or is currently being destroyed.
   content::WebContents* GetWebContents();
 
   // Returns true if |params| requires no more work to be done.
   bool IsComplete(const InstallableParams& params) const;
 
   // Resets members to empty and removes all queued tasks.
   // Called when navigating to a new page or if the WebContents is destroyed
   // whilst waiting for a callback.
   void Reset();
 
   // Sets the fetched bit on the installable and icon subtasks.
   // Called if no manifest (or an empty manifest) was fetched from the site.
   void SetManifestDependentTasksComplete();
 
   // Methods coordinating and dispatching work for the current task.
-  void RunCallback(const Task& task, InstallableErrorCode error);
+  void RunCallback(const Task& task, InstallableStatusCode error);
   void StartNextTask();
   void WorkOnTask();
 
   // Data retrieval methods.
   void FetchManifest();
   void OnDidGetManifest(const GURL& manifest_url,
                         const content::Manifest& manifest);
 
   void CheckInstallable();
   bool IsManifestValidForWebApp(const content::Manifest& manifest);
@@ skipping 20 matching lines @@
   std::map<IconParams, IconProperty> icons_;
 
   bool is_active_;
 
   base::WeakPtrFactory<InstallableManager> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(InstallableManager);
 };
 
 #endif  // CHROME_BROWSER_INSTALLABLE_INSTALLABLE_MANAGER_H_