Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2178633002: [mojo-edk] Remove invalid DCHECK from early Mach port message processing (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 5 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Remove invalid DCHECK from early Mach port message processing This DCHECK is clearly not intentional and can't possibly be correct. It's not being hit in practice today due to the latency of ChannelMojo setup, but reducing that latency easily exposes it. TBRing because it's trivial. BUG=None TBR=yzshen@chromium.org Committed: https://crrev.com/f206568f257a6e09e38dd6641b46403cef75be05 Cr-Commit-Position: refs/heads/master@{#407261}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M mojo/edk/system/node_channel.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178633002/1
4 years, 5 months ago (2016-07-22 19:46:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 21:06:08 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f206568f257a6e09e38dd6641b46403cef75be05 Cr-Commit-Position: refs/heads/master@{#407261}
4 years, 5 months ago (2016-07-22 21:07:59 UTC) #5
yzshen1
4 years, 5 months ago (2016-07-22 23:12:55 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698