mojo/edk/system/node_channel.cc - Issue 2178633002: [mojo-edk] Remove invalid DCHECK from early Mach port message processing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/system/node_channel.cc

Issue 2178633002: [mojo-edk] Remove invalid DCHECK from early Mach port message processing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/edk/system/node_channel.cc

diff --git a/mojo/edk/system/node_channel.cc b/mojo/edk/system/node_channel.cc

index ce094c16711db665c9645d6cafcda2426f4842a6..114e2863560b88c443049dbb1de8764c3e6858ef 100644

--- a/mojo/edk/system/node_channel.cc

+++ b/mojo/edk/system/node_channel.cc

@@ -771,7 +771,6 @@ void NodeChannel::ProcessPendingMessagesWithMachPorts() {

pending_writes.swap(pending_write_messages_);

pending_relays.swap(pending_relay_messages_);

}

- DCHECK(pending_writes.empty() && pending_relays.empty());

while (!pending_writes.empty()) {

Channel::MessagePtr message = std::move(pending_writes.front());

« no previous file with comments | « no previous file | no next file » | no next file with comments »