Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2178583002: DM: don't redirect stderr to verbose.log (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: don't redirect stderr to verbose.log verbose.log is currently tricky to get to, so it's hurting more than it helps to direct stderr there. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2178583002 Committed: https://skia.googlesource.com/skia/+/a1ce2163906eeb1dd5c543215c25cea856eda6cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M dm/DM.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein_C
4 years, 5 months ago (2016-07-22 19:04:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178583002/1
4 years, 5 months ago (2016-07-22 19:04:52 UTC) #5
bungeman-skia
lgtm
4 years, 5 months ago (2016-07-22 19:10:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/a1ce2163906eeb1dd5c543215c25cea856eda6cb
4 years, 5 months ago (2016-07-22 19:23:53 UTC) #8
jcgregorio
On 2016/07/22 at 19:23:53, commit-bot wrote: > Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/a1ce2163906eeb1dd5c543215c25cea856eda6cb Actually verbose ...
4 years, 5 months ago (2016-07-22 20:01:55 UTC) #9
bungeman-skia
On 2016/07/22 20:01:55, jcgregorio wrote: > On 2016/07/22 at 19:23:53, commit-bot wrote: > > Committed ...
4 years, 5 months ago (2016-07-22 20:09:09 UTC) #10
mtklein
4 years, 5 months ago (2016-07-22 20:19:55 UTC) #11
Message was sent while issue was closed.
> Part of this I believe is the additional issue that we don't seem to be
> uploading the verbose.log when the step fails.

Yep.  With that fixed, I'd be prepared to revert this if the verbose.log link
shows up on this page: https://screenshot.googleplex.com/nGVt6yEVsZ1.png

Powered by Google App Engine
This is Rietveld 408576698