dm/DM.cpp - Issue 2178583002: DM: don't redirect stderr to verbose.log

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DM.cpp

Issue 2178583002: DM: don't redirect stderr to verbose.log (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DM.cpp

diff --git a/dm/DM.cpp b/dm/DM.cpp

index cccc92b9faf4b63b5a48187e63b563f709f32cbe..d931a9a8e981d599e69643df4ba958c58b529f06 100644

--- a/dm/DM.cpp

+++ b/dm/DM.cpp

@@ -1265,7 +1265,7 @@ int dm_main() {

gVLog = stderr;

} else if (!FLAGS_writePath.isEmpty()) {

sk_mkdir(FLAGS_writePath[0]);

- gVLog = freopen(SkOSPath::Join(FLAGS_writePath[0], "verbose.log").c_str(), "w", stderr);

+ gVLog = fopen(SkOSPath::Join(FLAGS_writePath[0], "verbose.log").c_str(), "w");

}

JsonWriter::DumpJson(); // It's handy for the bots to assume this is ~never missing.

« no previous file with comments | « no previous file | no next file » | no next file with comments »