Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2178533002: Revert of [system-health] Re-enable stories failing smoke test due to CSSImageValue issue (Closed)

Created:
4 years, 5 months ago by Mark P
Modified:
4 years, 5 months ago
Reviewers:
nednguyen, petrcermak
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [system-health] Re-enable stories failing smoke test due to CSSImageValue issue (patchset #1 id:1 of https://codereview.chromium.org/2166373002/ ) Reason for revert: See bug 630663. Causes regular failures in one nytimes smoke_test --- [1/1] benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:news:nytimes failed unexpectedly 256.4172s: [ RUN ] browse:news:nytimes Traceback (most recent call last): File "/b/swarm_slave/w/irtOOh2q/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 85, in _RunStoryAndProcessErrorIfNeeded state.RunStory(results) File "/b/swarm_slave/w/irtOOh2q/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 319, in RunStory self._current_page.Run(self) File "/b/swarm_slave/w/irtOOh2q/third_party/catapult/telemetry/telemetry/page/__init__.py", line 99, in Run self.RunPageInteractions(action_runner) File "/b/swarm_slave/w/irtOOh2q/tools/perf/page_sets/system_health/system_health_story.py", line 79, in RunPageInteractions self._DidLoadDocument(action_runner) File "/b/swarm_slave/w/irtOOh2q/tools/perf/page_sets/system_health/browsing_stories.py", line 61, in _DidLoadDocument self._ReadNewsItem(action_runner) File "/b/swarm_slave/w/irtOOh2q/tools/perf/page_sets/system_health/browsing_stories.py", line 66, in _ReadNewsItem action_runner.tab.WaitForDocumentReadyStateToBeComplete() File "/b/swarm_slave/w/irtOOh2q/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 70, in WaitForDocumentReadyStateToBeComplete 'document.readyState == "complete"', timeout) File "/b/swarm_slave/w/irtOOh2q/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 136, in WaitForJavaScriptExpression e.message + '\n' + debug_message) TimeoutException: Timed out while waiting 90s for IsJavaScriptExpressionTrue. Console output: (log) http://acdn.adnxs.com/mediation/mediation.js?cb=1469120806459:1: anx-mediation %cCONTINUE (log) http://acdn.adnxs.com/mediation/mediation.js?cb=1469120806459:1: anx-mediation: %cCONTINUE %ccreative ids 48524723 (log) http://acdn.adnxs.com/mediation/mediation.js?cb=1469120806459:1: anx-mediation: INIT -- (log) http://acdn.adnxs.com/mediation/mediation.js?cb=1469120806459:1: anx-mediation: NOBID 241ms (log) http://acdn.adnxs.com/mediation/mediation.js?cb=1469120806459:1: anx-mediation: CONTINUE 241ms (log) http://acdn.adnxs.com/mediation/mediation.js?cb=1469120806459:1: console.groupEnd (log) http://acdn.adnxs.com/mediation/mediation.js?cb=1469120806459:1: console.groupEnd [ FAILED ] browse:news:nytimes (248456 ms) --- Original issue's description: > [system-health] Re-enable stories failing smoke test due to CSSImageValue issue > > The problem has been fixed: https://codereview.chromium.org/2168903002/ > > BUG=630215 > > Committed: https://crrev.com/ec705c571737dd02f19e14320979ee531fa24382 > Cr-Commit-Position: refs/heads/master@{#406866} TBR=nednguyen@google.com,petrcermak@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=630215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/perf/benchmarks/system_health_smoke_test.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mark P
Created Revert of [system-health] Re-enable stories failing smoke test due to CSSImageValue issue
4 years, 5 months ago (2016-07-22 17:23:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178533002/1
4 years, 5 months ago (2016-07-22 17:23:26 UTC) #3
nednguyen
On 2016/07/22 17:23:26, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 5 months ago (2016-07-22 17:46:46 UTC) #5
Mark P
4 years, 5 months ago (2016-07-22 17:51:59 UTC) #6
On 2016/07/22 17:46:46, nednguyen wrote:
> On 2016/07/22 17:23:26, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> 
> We can disable just
>
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:news:nytimes

If you'd rather disable the failing test rather than reverting this changelist,
go ahead and do so.  I'm assigning you the bug.

Powered by Google App Engine
This is Rietveld 408576698