Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: tools/perf/benchmarks/system_health_smoke_test.py

Issue 2178533002: Revert of [system-health] Re-enable stories failing smoke test due to CSSImageValue issue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Run all system health stories used by system health benchmarks. 5 """Run all system health stories used by system health benchmarks.
6 6
7 Only memory benchmarks are used when running these stories to make the total 7 Only memory benchmarks are used when running these stories to make the total
8 cycle time manageable. Other system health benchmarks should be using the same 8 cycle time manageable. Other system health benchmarks should be using the same
9 stories as memory ones, only with fewer actions (no memory dumping). 9 stories as memory ones, only with fewer actions (no memory dumping).
10 """ 10 """
(...skipping 14 matching lines...) Expand all
25 25
26 def GetSystemHealthBenchmarksToSmokeTest(): 26 def GetSystemHealthBenchmarksToSmokeTest():
27 sh_benchmark_classes = discover.DiscoverClassesInModule( 27 sh_benchmark_classes = discover.DiscoverClassesInModule(
28 system_health, perf_benchmark.PerfBenchmark, 28 system_health, perf_benchmark.PerfBenchmark,
29 index_by_class_name=True).values() 29 index_by_class_name=True).values()
30 return list(b for b in sh_benchmark_classes if 30 return list(b for b in sh_benchmark_classes if
31 b.Name().startswith('system_health.memory')) 31 b.Name().startswith('system_health.memory'))
32 32
33 33
34 _DISABLED_TESTS = frozenset({ 34 _DISABLED_TESTS = frozenset({
35 # crbug.com/630215
36 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:nytimes', # pylint: disable=line-too-long
37 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:reddit', # pylint: disable=line-too-long
35 # crbug.com/622409 38 # crbug.com/622409
36 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:cnn', # pylint: disable=line-too-long 39 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:cnn', # pylint: disable=line-too-long
37 # crbug.com/629123 40 # crbug.com/629123
38 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:hackernews', # pylint: disable=line-too-long 41 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:hackernews', # pylint: disable=line-too-long
39 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:nytimes', # pylint: disable=line-too-long 42 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:nytimes', # pylint: disable=line-too-long
40 }) 43 })
41 44
42 45
43 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test): 46 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test):
44 47
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 # parsed during test time which happens after load_tests are called. 126 # parsed during test time which happens after load_tests are called.
124 # Since none of our system health benchmarks creates stories based on 127 # Since none of our system health benchmarks creates stories based on
125 # command line options, it should be ok to pass options=None to 128 # command line options, it should be ok to pass options=None to
126 # CreateStorySet. 129 # CreateStorySet.
127 for story_to_smoke_test in ( 130 for story_to_smoke_test in (
128 benchmark_class().CreateStorySet(options=None).stories): 131 benchmark_class().CreateStorySet(options=None).stories):
129 suite.addTest( 132 suite.addTest(
130 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test)) 133 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test))
131 134
132 return suite 135 return suite
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698