Add layout test to make sure origin clean flag is preserved

Add layout test to make sure origin clean flag is preserved

This CL adds a layout test to make sure that the ImageBitmap's origin
clean flag is preserved after ImageBitmap is being transfered or
structured-cloned.

The test works like this: load a cross-origin image, and create an
ImageBitmap from that image. The promise of creating the ImageBitmap
should be resolved but the ImageBitmap is tainted. We then transfer the
ImageBitmap to the worker, and worker structure-clones the ImageBitmap
to the main. We then exam to make sure that the ImageBitmap is still
tained.

BUG=623406
Committed: https://crrev.com/2a8242617ffe25ee8738151c768ee41af29c3695
Cr-Commit-Position: refs/heads/master@{#407831}

[xidachen, 2016-07-22 16:38:12]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org

[xidachen, 2016-07-22 16:38:12]

PTAL

[Justin Novosad, 2016-07-26 14:07:52]

https://codereview.chromium.org/2178513002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html
(right):

https://codereview.chromium.org/2178513002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html:44:
resolve(replyPromise);
This is a nested promise. I am pretty sure the test is not testing the right
thing. I.e., the test will succeed after the imageBitmap is created (when the
top level promise is resolved), and may not wait for should be tained to be
called.  IMHO test would be clearer if it were written as an async test insted
of a promise test. With a simple call to t.done at the end of shouldBeTainted.

https://codereview.chromium.org/2178513002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html:47:
image.src = 'http://localhost:8080/security/resources/abe.png';
Not the best thing to hard code 'http://localhost:8080'. Could you use a
relative path instead?

[xidachen, 2016-07-26 15:13:11]

https://codereview.chromium.org/2178513002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html
(right):

https://codereview.chromium.org/2178513002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html:44:
resolve(replyPromise);
On 2016/07/26 14:07:52, Justin Novosad wrote:
> This is a nested promise. I am pretty sure the test is not testing the right
> thing. I.e., the test will succeed after the imageBitmap is created (when the
> top level promise is resolved), and may not wait for should be tained to be
> called.  IMHO test would be clearer if it were written as an async test insted
> of a promise test. With a simple call to t.done at the end of shouldBeTainted.

Changed to async_test in the new patch.

https://codereview.chromium.org/2178513002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html:47:
image.src = 'http://localhost:8080/security/resources/abe.png';
On 2016/07/26 14:07:52, Justin Novosad wrote:
> Not the best thing to hard code 'http://localhost:8080'. Could you use a
> relative path instead?

Per off-line discussion, will leave the path as localhost:8080

[Justin Novosad, 2016-07-26 15:28:45]

lgtm

https://codereview.chromium.org/2178513002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html
(right):

https://codereview.chromium.org/2178513002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html:44:
}, 'Transfer or structured-clone an ImageBitmap should preserve the originClean
flag.');
or -> and

[xidachen, 2016-07-26 15:32:35]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 15:32:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 16:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 16:51:34]

Dry run: This issue passed the CQ dry run.

[xidachen, 2016-07-26 16:55:08]

The CQ bit was checked by xidachen@chromium.org

[xidachen, 2016-07-26 16:55:08]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2178513002/#ps60001
(title: "nits")

[commit-bot: I haz the power, 2016-07-26 16:55:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 17:04:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-26 17:07:26]

Description was changed from

==========
Add layout test to make sure origin clean flag is preserved

This CL adds a layout test to make sure that the ImageBitmap's origin
clean flag is preserved after ImageBitmap is being transfered or
structured-cloned.

The test works like this: load a cross-origin image, and create an
ImageBitmap from that image. The promise of creating the ImageBitmap
should be resolved but the ImageBitmap is tainted. We then transfer the
ImageBitmap to the worker, and worker structure-clones the ImageBitmap
to the main. We then exam to make sure that the ImageBitmap is still
tained.

BUG=623406
==========

to

==========
Add layout test to make sure origin clean flag is preserved

This CL adds a layout test to make sure that the ImageBitmap's origin
clean flag is preserved after ImageBitmap is being transfered or
structured-cloned.

The test works like this: load a cross-origin image, and create an
ImageBitmap from that image. The promise of creating the ImageBitmap
should be resolved but the ImageBitmap is tainted. We then transfer the
ImageBitmap to the worker, and worker structure-clones the ImageBitmap
to the main. We then exam to make sure that the ImageBitmap is still
tained.

BUG=623406

Committed: https://crrev.com/2a8242617ffe25ee8738151c768ee41af29c3695
Cr-Commit-Position: refs/heads/master@{#407831}
==========

[commit-bot: I haz the power, 2016-07-26 17:07:27]

Patchset 4 (id:??) landed as
https://crrev.com/2a8242617ffe25ee8738151c768ee41af29c3695
Cr-Commit-Position: refs/heads/master@{#407831}