Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 2178513002: Add layout test to make sure origin clean flag is preserved (Closed)

4 years ago by xidachen
4 years ago
Justin Novosad
chromium-reviews, blink-reviews
Base URL:
Target Ref:


Add layout test to make sure origin clean flag is preserved This CL adds a layout test to make sure that the ImageBitmap's origin clean flag is preserved after ImageBitmap is being transfered or structured-cloned. The test works like this: load a cross-origin image, and create an ImageBitmap from that image. The promise of creating the ImageBitmap should be resolved but the ImageBitmap is tainted. We then transfer the ImageBitmap to the worker, and worker structure-clones the ImageBitmap to the main. We then exam to make sure that the ImageBitmap is still tained. BUG=623406 Committed: Cr-Commit-Position: refs/heads/master@{#407831}

Patch Set 1 #

Patch Set 2 : favoring one test file #

Total comments: 4

Patch Set 3 : changed to async_test #

Total comments: 1

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html View 1 2 3 1 chunk +47 lines, -0 lines 0 comments Download


Total messages: 15 (8 generated)
4 years ago (2016-07-22 16:38:12 UTC) #2
Justin Novosad File third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html (right): third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html:44: resolve(replyPromise); This is a nested promise. I am pretty ...
4 years ago (2016-07-26 14:07:52 UTC) #3
xidachen File third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html (right): third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html:44: resolve(replyPromise); On 2016/07/26 14:07:52, Justin Novosad wrote: > This ...
4 years ago (2016-07-26 15:13:11 UTC) #4
Justin Novosad
lgtm File third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html (right): third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html:44: }, 'Transfer or structured-clone an ImageBitmap should preserve ...
4 years ago (2016-07-26 15:28:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at
4 years ago (2016-07-26 16:55:15 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-07-26 17:04:54 UTC) #13
commit-bot: I haz the power
4 years ago (2016-07-26 17:07:27 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
Cr-Commit-Position: refs/heads/master@{#407831}

Powered by Google App Engine
This is Rietveld 408576698