Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1587683002: Update Clang update.py for the 3.9.0 version bump (Closed)

Created:
4 years, 11 months ago by hans
Modified:
4 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
hans
This is similar to how we did it last time (https://codereview.chromium.org/1239653004). Please take a look.
4 years, 11 months ago (2016-01-13 17:22:03 UTC) #2
Nico
What about these: https://code.google.com/p/chromium/codesearch#chromium/src/base/BUILD.gn&q=3%5C.8%5C.0&sq=package:chromium&l=1134&ct=rc&cd=2&dr=C https://code.google.com/p/chromium/codesearch#chromium/src/native_client/SConstruct&q=3%5C.8%5C.0&sq=package:chromium&l=2312&ct=rc&cd=3&dr=C https://code.google.com/p/chromium/codesearch#chromium/src/native_client/SConstruct&q=3%5C.8%5C.0&sq=package:chromium&l=2312&ct=rc&cd=3&dr=C Rev when roll happens? This lgtm; better than not ...
4 years, 11 months ago (2016-01-13 17:41:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587683002/1
4 years, 11 months ago (2016-01-13 17:44:18 UTC) #5
hans
On 2016/01/13 17:41:11, Nico wrote: > What about these: > > https://code.google.com/p/chromium/codesearch#chromium/src/base/BUILD.gn&q=3%5C.8%5C.0&sq=package:chromium&l=1134&ct=rc&cd=2&dr=C > https://code.google.com/p/chromium/codesearch#chromium/src/native_client/SConstruct&q=3%5C.8%5C.0&sq=package:chromium&l=2312&ct=rc&cd=3&dr=C > ...
4 years, 11 months ago (2016-01-13 17:45:15 UTC) #6
Nico
third link was supposed to be https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/recipe_modules/chromium_android/api.py&q=3%5C.8%5C.0%20-file:third_party/llvm&sq=package:chromium&type=cs&l=503
4 years, 11 months ago (2016-01-13 17:46:40 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/742a1e0d3c040f5f948f236978f00d19d6de1cb8 Cr-Commit-Position: refs/heads/master@{#369210}
4 years, 11 months ago (2016-01-13 17:51:32 UTC) #9
hans
4 years, 11 months ago (2016-01-13 17:51:58 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
742a1e0d3c040f5f948f236978f00d19d6de1cb8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698