Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2178473002: omnibox: make decorations non-focusable for now (Closed)

Created:
4 years, 5 months ago by Elly Fong-Jones
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

omnibox: make decorations non-focusable for now The key view loop is messed up for these decorations, as described in https://crbug.com/623883, so let's make them non-focusable pending a real fix. BUG=623883 Review-Url: https://codereview.chromium.org/2155233002 Cr-Commit-Position: refs/heads/master@{#406376} (cherry picked from commit bd2ba8d0939223348e7b01d5c0398fde744fb72f) Committed: https://chromium.googlesource.com/chromium/src/+/a07d9c1793708519b7ffb1ecf776e4a0deb3b9f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Elly Fong-Jones
4 years, 5 months ago (2016-07-22 14:56:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a07d9c1793708519b7ffb1ecf776e4a0deb3b9f3.

Powered by Google App Engine
This is Rietveld 408576698