Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2155233002: omnibox: make decorations non-focusable for now (Closed)

Created:
4 years, 5 months ago by Elly Fong-Jones
Modified:
4 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

omnibox: make decorations non-focusable for now The key view loop is messed up for these decorations, as described in https://crbug.com/623883, so let's make them non-focusable pending a real fix. BUG=623883 Committed: https://crrev.com/bd2ba8d0939223348e7b01d5c0398fde744fb72f Cr-Commit-Position: refs/heads/master@{#406376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Elly Fong-Jones
mark: ptal? :)
4 years, 5 months ago (2016-07-18 17:34:57 UTC) #3
Mark Mentovai
LGTM
4 years, 5 months ago (2016-07-19 20:09:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155233002/1
4 years, 5 months ago (2016-07-19 20:10:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 20:59:04 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 20:59:07 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 21:00:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd2ba8d0939223348e7b01d5c0398fde744fb72f
Cr-Commit-Position: refs/heads/master@{#406376}

Powered by Google App Engine
This is Rietveld 408576698