MD Settings: add a <controlled-button> that uses prefs to disable itself

MD Settings: add a <controlled-button> that uses prefs to disable itself

R=stevenjb@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c70c674fc869d73de105d28190b2b30c510e9935
Cr-Commit-Position: refs/heads/master@{#407985}

[Dan Beam, 2016-07-26 05:03:36]

Description was changed from

==========
MD Settings: add a <controlled-button> that uses prefs to disable itself

R=stevenjb@chromium.org
BUG=614265
==========

to

==========
MD Settings: add a <controlled-button> that uses prefs to disable itself

R=stevenjb@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-07-26 05:06:25]

Patchset #1 (id:1) has been deleted

[stevenjb, 2016-07-26 16:19:34]

FWIW, I think pref_controlled_button would be more clear, but this seems fine
also.

lgtm with one other naming suggestion.

https://codereview.chromium.org/2178273002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/controlled_button.html (right):

https://codereview.chromium.org/2178273002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/controlled_button.html:17:
<paper-button disabled="[[disabled_]]">
'disabled_' confused me for a bit, maybe 'prefDisabled_' or 'disabledByPref_'?

[Dan Beam, 2016-07-26 19:36:50]

can you take another look?  I actually hadn't sent it for review yet, but code
review is funky (and shows unpublished reviews in your queue).

https://codereview.chromium.org/2178273002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/controlled_button.html (right):

https://codereview.chromium.org/2178273002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/controlled_button.html:17:
<paper-button disabled="[[disabled_]]">
On 2016/07/26 16:19:34, stevenjb wrote:
> 'disabled_' confused me for a bit, maybe 'prefDisabled_' or 'disabledByPref_'?

I actually changed to "disabled" as it matches a :host([disabled]) {
pointer-events: none; } rule in cr_elements/shared.css when reflected to an
attribute on the host

[Dan Beam, 2016-07-26 19:38:40]

and I could change the name, yeah.  I was hoping to make some of this stuff
eventually generic enough that an extension controlling something could also
possibly use the same UI/class.

it's also weird to call something "pref controlled" as it's actually "policy
controlled", but realllly "policy is controlling the pref which disables this
UI"... which is a long tag name :)

[Dan Beam, 2016-07-26 19:38:54]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 19:39:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2016-07-26 19:50:09]

https://codereview.chromium.org/2178273002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/controlled_button.html (right):

https://codereview.chromium.org/2178273002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/controls/controlled_button.html:27: <template
is="dom-if" if="[[disabled]]">
If we use |disabled|, then I think this needs to be [[disabled && !!pref]]
(which will need to be wrapped in a function of course). <controlled-button
disabled> with no pref would be unexpected but valid.

[commit-bot: I haz the power, 2016-07-26 20:40:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 20:40:25]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-07-26 22:28:41]

https://codereview.chromium.org/2178273002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/controlled_button.html (right):

https://codereview.chromium.org/2178273002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/controls/controlled_button.html:27: <template
is="dom-if" if="[[disabled]]">
On 2016/07/26 19:50:09, stevenjb wrote:
> If we use |disabled|, then I think this needs to be [[disabled && !!pref]]
> (which will need to be wrapped in a function of course). <controlled-button
> disabled> with no pref would be unexpected but valid.

change to controlled_

https://codereview.chromium.org/2178273002/diff/80001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html
(right):

https://codereview.chromium.org/2178273002/diff/80001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html:25:
<paper-tooltip for="indicator" position="top" fit-to-visible-bounds>
i can split these to a separate change if you'd like

[stevenjb, 2016-07-26 23:11:41]

lgtm

[Dan Beam, 2016-07-26 23:13:12]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-07-26 23:13:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 00:21:28]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-07-27 00:24:06]

Description was changed from

==========
MD Settings: add a <controlled-button> that uses prefs to disable itself

R=stevenjb@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: add a <controlled-button> that uses prefs to disable itself

R=stevenjb@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c70c674fc869d73de105d28190b2b30c510e9935
Cr-Commit-Position: refs/heads/master@{#407985}
==========

[commit-bot: I haz the power, 2016-07-27 00:24:07]

Patchset 5 (id:??) landed as
https://crrev.com/c70c674fc869d73de105d28190b2b30c510e9935
Cr-Commit-Position: refs/heads/master@{#407985}