chrome/browser/resources/settings/controls/controlled_button.html - Issue 2178273002: MD Settings: add a <controlled-button> that uses prefs to disable itself

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/controls/controlled_button.html

Issue 2178273002: MD Settings: add a <controlled-button> that uses prefs to disable itself (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: asdf Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/controls/controlled_button.js » ('j') | ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

	3 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_pref_be havior.html">

	4 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_pref_in dicator.html">

	5 <link rel="import" href="/controls/pref_control_behavior.html">

	6 <link rel="import" href="/settings_shared_css.html">

	7

	8 <dom-module id="controlled-button">

	9 <link rel="import" type="css" href="chrome://resources/cr_elements/shared.css" >

	10 <template>

	11 <style include="settings-shared">

	12 :host {

	13 align-items: center;

	14 display: flex;

	15 }

	16

	17 cr-policy-pref-indicator {

	18 -webkit-margin-start: var(--checkbox-spacing);

	19 pointer-events: all;

	20 }

	21 </style>

	22

	23 <paper-button disabled="[[disabled]]">

	24 <content></content>

	25 </paper-button>

	26

	27 <template is="dom-if" if="[[disabled]]">
	stevenjb 2016/07/26 19:50:09 If we use \|disabled\|, then I think this needs to b If we use \|disabled\|, then I think this needs to be [[disabled && !!pref]] (which will need to be wrapped in a function of course). <controlled-button disabled> with no pref would be unexpected but valid. Dan Beam 2016/07/26 22:28:40 change to controlled_ Show quoted text On 2016/07/26 19:50:09, stevenjb wrote: > If we use \|disabled\|, then I think this needs to be [[disabled && !!pref]] > (which will need to be wrapped in a function of course). <controlled-button > disabled> with no pref would be unexpected but valid. change to controlled_
	28 <cr-policy-pref-indicator pref="[[pref]]" on-tap="onIndicatorTap_">

	29 </cr-policy-pref-indicator>

	30 </template>

	31

	32 </template>

	33 <script src="/controls/controlled_button.js"></script>

	34 </dom-module>

OLD	NEW