Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/modules/csspaint/PaintWorklet.h

Issue 2178223002: Refactor Worklet class to use ScriptResource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed redundant ExecutionContext parameter, changed WorkletScriptLoader to inherit from ResourceO… Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h ('K') | « third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.cpp ('k') | third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp » ('j') | third_party/WebKit/Source/modules/worklet/Worklet.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/csspaint/PaintWorklet.h
diff --git a/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h b/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h
index 5d3a016f563eb82a6d8efd01dfe8205ecae71a09..85c1b2b1283207fa06532fad1295e4b52ed81060 100644
--- a/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h
+++ b/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h
@@ -18,7 +18,7 @@ class CSSPaintImageGeneratorImpl;
class MODULES_EXPORT PaintWorklet final : public Worklet {
WTF_MAKE_NONCOPYABLE(PaintWorklet);
public:
- static PaintWorklet* create(LocalFrame*, ExecutionContext*);
+ static PaintWorklet* create(LocalFrame*);
~PaintWorklet() override;
PaintWorkletGlobalScope* workletGlobalScopeProxy() const final;
@@ -28,7 +28,7 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
- PaintWorklet(LocalFrame*, ExecutionContext*);
+ PaintWorklet(LocalFrame*);
yhirano 2016/08/01 10:56:28 +explicit
Gleb Lanbin 2016/08/01 19:49:50 Done.
Member<PaintWorkletGlobalScope> m_paintWorkletGlobalScope;
};
« third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h ('K') | « third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.cpp ('k') | third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp » ('j') | third_party/WebKit/Source/modules/worklet/Worklet.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698