third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h - Issue 2178223002: Refactor Worklet class to use ScriptResource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h

Issue 2178223002: Refactor Worklet class to use ScriptResource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed redundant ExecutionContext parameter, changed WorkletScriptLoader to inherit from ResourceO… Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkletGlobalScopeProxy.h ('k') | third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp » ('j') | third_party/WebKit/Source/modules/csspaint/PaintWorklet.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h

diff --git a/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h b/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h

index 34e5c21a2ecb14b3e75d0ed2193810a804571e36..610555e33cf915a0635bc186f3cd0f2832775ddf 100644

--- a/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h

+++ b/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h

@@ -11,13 +11,14 @@

namespace blink {

+class LocalFrame;

class ThreadedWorkletGlobalScopeProxy;

class WorkletGlobalScopeProxy;

class MODULES_EXPORT AnimationWorklet final : public Worklet {

WTF_MAKE_NONCOPYABLE(AnimationWorklet);

public:

- static AnimationWorklet* create(ExecutionContext*);

+ static AnimationWorklet* create(LocalFrame*);

~AnimationWorklet() override;

WorkletGlobalScopeProxy* workletGlobalScopeProxy() const final;

@@ -25,7 +26,7 @@ public:

DECLARE_VIRTUAL_TRACE();

private:

- AnimationWorklet(ExecutionContext*);

+ AnimationWorklet(LocalFrame*);

yhirano 2016/08/01 10:56:27 +explicit

Gleb Lanbin 2016/08/01 19:49:50 Done.

// TODO(ikilpatrick): this will change to a raw ptr once we have a thread.

std::unique_ptr<ThreadedWorkletGlobalScopeProxy> m_workletGlobalScopeProxy;