Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: chrome/browser/safe_browsing/ui_manager.h

Issue 2178213003: Update RequestTrigger to GestureType in permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/ui_manager.h
diff --git a/chrome/browser/safe_browsing/ui_manager.h b/chrome/browser/safe_browsing/ui_manager.h
index af1e510c9b5a3b1092868df5d3deed7f635dc2d9..6cd868f2a6effb885f4b0dd476b462aee5c6e15f 100644
--- a/chrome/browser/safe_browsing/ui_manager.h
+++ b/chrome/browser/safe_browsing/ui_manager.h
@@ -35,6 +35,8 @@ namespace net {
class SSLInfo;
} // namespace net
+enum class PermissionRequestGestureType;
kcarattini 2016/07/26 06:03:26 Where is this defined?
stefanocs 2016/07/26 06:08:31 It should be in chrome/browser/permissions/permiss
raymes 2016/07/27 01:42:05 same here
stefanocs 2016/07/27 02:58:18 Done.
+
namespace safe_browsing {
class SafeBrowsingService;
@@ -156,7 +158,7 @@ class SafeBrowsingUIManager
content::PermissionType permission,
PermissionAction action,
PermissionSourceUI source_ui,
- bool user_gesture);
+ PermissionRequestGestureType gesture_type);
// Add and remove observers. These methods must be invoked on the UI thread.
void AddObserver(Observer* observer);
@@ -179,11 +181,12 @@ class SafeBrowsingUIManager
const std::string& serialized_report);
// Report permission action to SafeBrowsing servers.
- void ReportPermissionActionOnIOThread(const GURL& origin,
- content::PermissionType permission,
- PermissionAction action,
- PermissionSourceUI source_ui,
- bool user_gesture);
+ void ReportPermissionActionOnIOThread(
+ const GURL& origin,
+ content::PermissionType permission,
+ PermissionAction action,
+ PermissionSourceUI source_ui,
+ PermissionRequestGestureType gesture_type);
// Updates the whitelist state. Called on the UI thread.
void AddToWhitelist(const UnsafeResource& resource);

Powered by Google App Engine
This is Rietveld 408576698