chrome/browser/resources/settings/device_page/note.html - Issue 2178213002: Add note page to settings.

Unified Diff: chrome/browser/resources/settings/device_page/note.html

Issue 2178213002: Add note page to settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stylus-add-switch

Patch Set: Initial upload Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/device_page/device_page.html ('K') | « chrome/browser/resources/settings/device_page/device_page.js ('k') | chrome/browser/resources/settings/device_page/note.js » ('j') | chrome/browser/ui/webui/settings/chromeos/note_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/device_page/note.html

diff --git a/chrome/browser/resources/settings/device_page/note.html b/chrome/browser/resources/settings/device_page/note.html

new file mode 100644

index 0000000000000000000000000000000000000000..a24cbff768f7de519fd24991ce07ab16f7711a1a

--- /dev/null

+++ b/chrome/browser/resources/settings/device_page/note.html

@@ -0,0 +1,34 @@

+<link rel="import" href="chrome://resources/html/polymer.html">

+<link rel="import" href="/controls/settings_checkbox.html">

+<link rel="import" href="/settings_shared_css.html">

+<dom-module id="settings-note">

+ <template>

+ <style include="settings-shared">

+ a {

+ color: rgb(66, 133, 244);

+ text-decoration: none;

+ }

stevenjb 2016/07/26 23:21:39 Not needed, see below.

jdufault 2016/07/27 20:55:02 Done.

+ </style>

+ <div class="settings-box">

+

+ <settings-checkbox

+ pref="{{prefs.settings.launch_note_app_on_eject_event}}"

+ label="Launch note-taking app when removing stylus">

+ </settings-checkbox>

+ </div>

+ <div class="settings-box">

+ <!-- TODO(jdufault): This should launch an intent (using the

+ enable-intent-picker flag) that opens up the play store to a curated

+ list of apps. -->

+ <a href="https://chrome.google.com/webstore/category/apps"

+ target="_blank">Find note apps</a>

stevenjb 2016/07/26 23:21:39 Add is="action-link" which will pick up styling, s

jdufault 2016/07/27 20:55:02 Done.

+ </div>

+

+ <div class="settings-box"></div>

stevenjb 2016/07/26 23:21:39 This shouldn't be needed...

jdufault 2016/07/27 20:55:01 I'm fine having it not be there, but the mocks inc

stevenjb 2016/07/27 22:29:42 I added a comment in folio. That is inconsistent w

jdufault 2016/07/28 17:54:40 Sounds good, thanks!

+ </template>

+ <script src="note.js"></script>

+</dom-module>