chrome/browser/resources/settings/device_page/note.html - Issue 2178213002: Add note page to settings.

Side by Side Diff: chrome/browser/resources/settings/device_page/note.html

Issue 2178213002: Add note page to settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stylus-add-switch

Patch Set: Initial upload Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/device_page/device_page.html ('K') | « chrome/browser/resources/settings/device_page/device_page.js ('k') | chrome/browser/resources/settings/device_page/note.js » ('j') | chrome/browser/ui/webui/settings/chromeos/note_handler.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="/controls/settings_checkbox.html">

	3 <link rel="import" href="/settings_shared_css.html">

	4

	5 <dom-module id="settings-note">

	6 <template>

	7 <style include="settings-shared">

	8 a {

	9 color: rgb(66, 133, 244);

	10 text-decoration: none;

	11 }
	stevenjb 2016/07/26 23:21:39 Not needed, see below. Not needed, see below. jdufault 2016/07/27 20:55:02 Done. Show quoted text On 2016/07/26 23:21:39, stevenjb wrote: > Not needed, see below. Done.
	12 </style>

	13

	14 <div class="settings-box">

	15 <!-- TODO(jdufault): i18n -->

	16 <settings-checkbox

	17 pref="{{prefs.settings.launch_note_app_on_eject_event}}"

	18 label="Launch note-taking app when removing stylus">

	19 </settings-checkbox>

	20 </div>

	21 <div class="settings-box">

	22 <!-- TODO(jdufault): This should launch an intent (using the

	23 enable-intent-picker flag) that opens up the play store to a curated

	24 list of apps. -->

	25 <a href="https://chrome.google.com/webstore/category/apps"

	26 target="_blank">Find note apps</a>
	stevenjb 2016/07/26 23:21:39 Add is="action-link" which will pick up styling, s Add is="action-link" which will pick up styling, see other examples in this directory. jdufault 2016/07/27 20:55:02 Done. Show quoted text On 2016/07/26 23:21:39, stevenjb wrote: > Add is="action-link" which will pick up styling, see other examples in this > directory. Done.
	27 </div>

	28

	29 <!-- Draw final horizontal rule. -->

	30 <div class="settings-box"></div>
	stevenjb 2016/07/26 23:21:39 This shouldn't be needed... This shouldn't be needed... jdufault 2016/07/27 20:55:01 I'm fine having it not be there, but the mocks inc Show quoted text On 2016/07/26 23:21:39, stevenjb wrote: > This shouldn't be needed... I'm fine having it not be there, but the mocks include it. I've dropped it for the time being. stevenjb 2016/07/27 22:29:42 I added a comment in folio. That is inconsistent w Show quoted text On 2016/07/27 20:55:01, jdufault wrote: > On 2016/07/26 23:21:39, stevenjb wrote: > > This shouldn't be needed... > > I'm fine having it not be there, but the mocks include it. I've dropped it for > the time being. I added a comment in folio. That is inconsistent with other settings mocks. If we change the design we should add a better way, e.g. class="settings-box last" jdufault 2016/07/28 17:54:40 Sounds good, thanks! Show quoted text On 2016/07/27 22:29:42, stevenjb wrote: > On 2016/07/27 20:55:01, jdufault wrote: > > On 2016/07/26 23:21:39, stevenjb wrote: > > > This shouldn't be needed... > > > > I'm fine having it not be there, but the mocks include it. I've dropped it for > > the time being. > > I added a comment in folio. That is inconsistent with other settings mocks. If > we change the design we should add a better way, e.g. class="settings-box last" Sounds good, thanks!
	31

	32 </template>

	33 <script src="note.js"></script>

	34 </dom-module>

OLD	NEW