Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 21782002: Replaced unary negation by multiplication with -1. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/typing.cc ('k') | test/mjsunit/unary-minus-deopt.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4317 matching lines...) Expand 10 before | Expand all | Expand 10 after
4328 case Token::TYPEOF: { 4328 case Token::TYPEOF: {
4329 Comment cmnt(masm_, "[ UnaryOperation (TYPEOF)"); 4329 Comment cmnt(masm_, "[ UnaryOperation (TYPEOF)");
4330 { StackValueContext context(this); 4330 { StackValueContext context(this);
4331 VisitForTypeofValue(expr->expression()); 4331 VisitForTypeofValue(expr->expression());
4332 } 4332 }
4333 __ CallRuntime(Runtime::kTypeof, 1); 4333 __ CallRuntime(Runtime::kTypeof, 1);
4334 context()->Plug(rax); 4334 context()->Plug(rax);
4335 break; 4335 break;
4336 } 4336 }
4337 4337
4338 case Token::SUB:
4339 EmitUnaryOperation(expr, "[ UnaryOperation (SUB)");
4340 break;
4341
4342 case Token::BIT_NOT: 4338 case Token::BIT_NOT:
4343 EmitUnaryOperation(expr, "[ UnaryOperation (BIT_NOT)"); 4339 EmitUnaryOperation(expr, "[ UnaryOperation (BIT_NOT)");
4344 break; 4340 break;
4345 4341
4346 default: 4342 default:
4347 UNREACHABLE(); 4343 UNREACHABLE();
4348 } 4344 }
4349 } 4345 }
4350 4346
4351 4347
4352 void FullCodeGenerator::EmitUnaryOperation(UnaryOperation* expr, 4348 void FullCodeGenerator::EmitUnaryOperation(UnaryOperation* expr,
4353 const char* comment) { 4349 const char* comment) {
4350 ASSERT_EQ(Token::BIT_NOT, expr->op());
4354 // TODO(svenpanne): Allowing format strings in Comment would be nice here... 4351 // TODO(svenpanne): Allowing format strings in Comment would be nice here...
4355 Comment cmt(masm_, comment); 4352 Comment cmt(masm_, comment);
4356 UnaryOpStub stub(expr->op()); 4353 UnaryOpStub stub(expr->op());
4357 // UnaryOpStub expects the argument to be in the 4354 // UnaryOpStub expects the argument to be in the
4358 // accumulator register rax. 4355 // accumulator register rax.
4359 VisitForAccumulatorValue(expr->expression()); 4356 VisitForAccumulatorValue(expr->expression());
4360 SetSourcePosition(expr->position()); 4357 SetSourcePosition(expr->position());
4361 CallIC(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, 4358 CallIC(stub.GetCode(isolate()), RelocInfo::CODE_TARGET,
4362 expr->UnaryOperationFeedbackId()); 4359 expr->UnaryOperationFeedbackId());
4363 context()->Plug(rax); 4360 context()->Plug(rax);
(...skipping 541 matching lines...) Expand 10 before | Expand all | Expand 10 after
4905 *context_length = 0; 4902 *context_length = 0;
4906 return previous_; 4903 return previous_;
4907 } 4904 }
4908 4905
4909 4906
4910 #undef __ 4907 #undef __
4911 4908
4912 } } // namespace v8::internal 4909 } } // namespace v8::internal
4913 4910
4914 #endif // V8_TARGET_ARCH_X64 4911 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/typing.cc ('k') | test/mjsunit/unary-minus-deopt.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698