Allow GN toolchains to specify runtime deps outputs.

Allow GN toolchains to specify runtime deps outputs.

Previously the file considered for the runtime deps computation for linked
targets was just the first output, or, for shared libraries, the
runtime_link_output.

This patch changes that to a list of files for all linker tools. This will
allow us, for example, to be able to automatically bundle symbol files
generated by the build (but not .lib files in the case of shared libraries) to
the swarming bots for testing.

The tool class setters now take objects by copies and move them to avoid extra
copies in many cases. Add a defined_from member to the Tool class.

BUG=631242
Committed: https://crrev.com/15e0e74f4dbd7616a722702eedd6620b70f50290
Cr-Commit-Position: refs/heads/master@{#407852}

[brettw, 2016-07-25 22:28:52]

Description was changed from

==========
Allow GN toolchains to specify runtime deps outputs.

Previously the file considered for the runtime deps computation for linked
targets was just the first output, or, fo shared libraries, the
runtime_link_output.

This patch changes that to a list of files for all linker tools. This will
allow us, for example, to be able to automatically bundle symbol files
generated by the build (but not .lib files in the case of shared libraries) to
the swarming bots for testing.

BUG=631242
==========

to

==========
Allow GN toolchains to specify runtime deps outputs.

Previously the file considered for the runtime deps computation for linked
targets was just the first output, or, fo shared libraries, the
runtime_link_output.

This patch changes that to a list of files for all linker tools. This will
allow us, for example, to be able to automatically bundle symbol files
generated by the build (but not .lib files in the case of shared libraries) to
the swarming bots for testing.

The tool class setters now take objects by copies and move them to avoid extra
copies in many cases. Add a defined_from member to the Tool class.

BUG=631242
==========

[brettw, 2016-07-25 22:29:01]

.

[brettw, 2016-07-25 22:29:02]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-07-25 22:29:13]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[commit-bot: I haz the power, 2016-07-25 22:29:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-07-25 22:29:26]

Description was changed from

==========
Allow GN toolchains to specify runtime deps outputs.

Previously the file considered for the runtime deps computation for linked
targets was just the first output, or, fo shared libraries, the
runtime_link_output.

This patch changes that to a list of files for all linker tools. This will
allow us, for example, to be able to automatically bundle symbol files
generated by the build (but not .lib files in the case of shared libraries) to
the swarming bots for testing.

The tool class setters now take objects by copies and move them to avoid extra
copies in many cases. Add a defined_from member to the Tool class.

BUG=631242
==========

to

==========
Allow GN toolchains to specify runtime deps outputs.

Previously the file considered for the runtime deps computation for linked
targets was just the first output, or, fo shared libraries, the
runtime_link_output.

This patch changes that to a list of files for all linker tools. This will
allow us, for example, to be able to automatically bundle symbol files
generated by the build (but not .lib files in the case of shared libraries) to
the swarming bots for testing.

The tool class setters now take objects by copies and move them to avoid extra
copies in many cases. Add a defined_from member to the Tool class.

BUG=631242
==========

[Dirk Pranke, 2016-07-25 22:44:39]

Description was changed from

==========
Allow GN toolchains to specify runtime deps outputs.

Previously the file considered for the runtime deps computation for linked
targets was just the first output, or, fo shared libraries, the
runtime_link_output.

This patch changes that to a list of files for all linker tools. This will
allow us, for example, to be able to automatically bundle symbol files
generated by the build (but not .lib files in the case of shared libraries) to
the swarming bots for testing.

The tool class setters now take objects by copies and move them to avoid extra
copies in many cases. Add a defined_from member to the Tool class.

BUG=631242
==========

to

==========
Allow GN toolchains to specify runtime deps outputs.

Previously the file considered for the runtime deps computation for linked
targets was just the first output, or, for shared libraries, the
runtime_link_output.

This patch changes that to a list of files for all linker tools. This will
allow us, for example, to be able to automatically bundle symbol files
generated by the build (but not .lib files in the case of shared libraries) to
the swarming bots for testing.

The tool class setters now take objects by copies and move them to avoid extra
copies in many cases. Add a defined_from member to the Tool class.

BUG=631242
==========

[Dirk Pranke, 2016-07-25 22:52:18]

This CL leaves the {{output}} expansion unchanged for "solink", right?

If so, LGTM.

https://codereview.chromium.org/2178173002/diff/20001/tools/gn/function_toolc...
File tools/gn/function_toolchain.cc (right):

https://codereview.chromium.org/2178173002/diff/20001/tools/gn/function_toolc...
tools/gn/function_toolchain.cc:246: // the assocaited pattern, and the variable
name that should appear in error
typo: associated

[commit-bot: I haz the power, 2016-07-26 01:02:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 01:02:15]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[brettw, 2016-07-26 04:53:55]

fix

[brettw, 2016-07-26 04:53:56]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-07-26 04:53:57]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2178173002/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2016-07-26 04:54:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 05:47:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 05:47:32]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[brettw, 2016-07-26 16:59:30]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-07-26 16:59:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 18:00:41]

Description was changed from

==========
Allow GN toolchains to specify runtime deps outputs.

Previously the file considered for the runtime deps computation for linked
targets was just the first output, or, for shared libraries, the
runtime_link_output.

This patch changes that to a list of files for all linker tools. This will
allow us, for example, to be able to automatically bundle symbol files
generated by the build (but not .lib files in the case of shared libraries) to
the swarming bots for testing.

The tool class setters now take objects by copies and move them to avoid extra
copies in many cases. Add a defined_from member to the Tool class.

BUG=631242
==========

to

==========
Allow GN toolchains to specify runtime deps outputs.

Previously the file considered for the runtime deps computation for linked
targets was just the first output, or, for shared libraries, the
runtime_link_output.

This patch changes that to a list of files for all linker tools. This will
allow us, for example, to be able to automatically bundle symbol files
generated by the build (but not .lib files in the case of shared libraries) to
the swarming bots for testing.

The tool class setters now take objects by copies and move them to avoid extra
copies in many cases. Add a defined_from member to the Tool class.

BUG=631242
==========

[commit-bot: I haz the power, 2016-07-26 18:00:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-26 18:06:19]

Description was changed from

==========
Allow GN toolchains to specify runtime deps outputs.

Previously the file considered for the runtime deps computation for linked
targets was just the first output, or, for shared libraries, the
runtime_link_output.

This patch changes that to a list of files for all linker tools. This will
allow us, for example, to be able to automatically bundle symbol files
generated by the build (but not .lib files in the case of shared libraries) to
the swarming bots for testing.

The tool class setters now take objects by copies and move them to avoid extra
copies in many cases. Add a defined_from member to the Tool class.

BUG=631242
==========

to

==========
Allow GN toolchains to specify runtime deps outputs.

Previously the file considered for the runtime deps computation for linked
targets was just the first output, or, for shared libraries, the
runtime_link_output.

This patch changes that to a list of files for all linker tools. This will
allow us, for example, to be able to automatically bundle symbol files
generated by the build (but not .lib files in the case of shared libraries) to
the swarming bots for testing.

The tool class setters now take objects by copies and move them to avoid extra
copies in many cases. Add a defined_from member to the Tool class.

BUG=631242

Committed: https://crrev.com/15e0e74f4dbd7616a722702eedd6620b70f50290
Cr-Commit-Position: refs/heads/master@{#407852}
==========

[commit-bot: I haz the power, 2016-07-26 18:06:19]

Patchset 3 (id:??) landed as
https://crrev.com/15e0e74f4dbd7616a722702eedd6620b70f50290
Cr-Commit-Position: refs/heads/master@{#407852}