Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: build/toolchain/win/BUILD.gn

Issue 2178173002: Allow GN toolchains to specify runtime deps outputs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/win/BUILD.gn
diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn
index 7d98b030d515368cf8f5238a9d60ef7c3b62fbc1..d4c6dd46a0cfd5314cbf4b7b6bb6effb200fd855 100644
--- a/build/toolchain/win/BUILD.gn
+++ b/build/toolchain/win/BUILD.gn
@@ -192,6 +192,12 @@ template("msvc_toolchain") {
]
link_output = libname
depend_output = libname
+
+ # The new version of GN uses a runtime_outputs list rather than a
+ # runtime_link_output string. This needs to be flipped for the next GN
+ # roll.
+ # TODO(brettw) bug 631242: Swap this and remove the old one.
+ #runtime_outputs = [ dllname ]
runtime_link_output = dllname
# Since the above commands only updates the .lib file when it changes, ask
« no previous file with comments | « no previous file | tools/gn/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698