Add ink drop ripple to shelf overflow button

ui/views/controls/button/custom_button.cc

Index: ui/views/controls/button/custom_button.cc
diff --git a/ui/views/controls/button/custom_button.cc b/ui/views/controls/button/custom_button.cc
index 85dc33627b1d853aebe03296affa86e9b96f3618..763edeacc88f4660a526fefc4cc9ae77fa1a9b34 100644
--- a/ui/views/controls/button/custom_button.cc
+++ b/ui/views/controls/button/custom_button.cc
@@ -197,7 +197,7 @@ void CustomButton::OnMouseReleased(const ui::MouseEvent& event) {
       }
     }
   }
-  if (notify_action_ == NOTIFY_ON_RELEASE)
+  if (state_ == STATE_PRESSED && notify_action_ == NOTIFY_ON_RELEASE)

[bruthig, 2016/07/26 13:57:16]

What's the use case for this?  AFAICT this will never evaluate to true because
the previous block will either set the state to STATE_NORMAL, STATE_HOVERED, or
state_ == STATE_DISABLED.

[mohsen, 2016/07/26 20:00:58]

Sorry! This is totally wrong! The use case is that when the user presses on the
button when it is active, no pending ink drop is shown, so when click is
cancelled, ink drop should not get hidden. Here I wanted not to call
OnClickCanceled() when button is not in the pressed state (button is not
pressed, so there is nothing to cancel). But, that's not that easy and it is
better to be fixed separately. For now, I just changed the code to hide the
ripple only if it is not in activated state. (see
CustomButton::OnClickCanceled())

     OnClickCanceled(event);
 }