Add ink drop ripple to shelf overflow button

ui/views/controls/button/custom_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/custom_button.h"
 
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/material_design/material_design_controller.h"
 #include "ui/events/event.h"
 #include "ui/events/event_utils.h"
@@ skipping 179 matching lines @@
     } else {
       SetState(STATE_HOVERED);
       if (IsTriggerableEvent(event) && notify_action_ == NOTIFY_ON_RELEASE) {
         NotifyClick(event);
         // NOTE: We may be deleted at this point (by the listener's notification
         // handler).
         return;
       }
     }
   }
-  if (notify_action_ == NOTIFY_ON_RELEASE)
+  if (state_ == STATE_PRESSED && notify_action_ == NOTIFY_ON_RELEASE)

[bruthig, 2016/07/26 13:57:16]

What's the use case for this?  AFAICT this will never evaluate to true because
the previous block will either set the state to STATE_NORMAL, STATE_HOVERED, or
state_ == STATE_DISABLED.

[mohsen, 2016/07/26 20:00:58]

Sorry! This is totally wrong! The use case is that when the user presses on the
button when it is active, no pending ink drop is shown, so when click is
cancelled, ink drop should not get hidden. Here I wanted not to call
OnClickCanceled() when button is not in the pressed state (button is not
pressed, so there is nothing to cancel). But, that's not that easy and it is
better to be fixed separately. For now, I just changed the code to hide the
ripple only if it is not in activated state. (see
CustomButton::OnClickCanceled())

     OnClickCanceled(event);
 }
 
 void CustomButton::OnMouseCaptureLost() {
   // Starting a drag results in a MouseCaptureLost. Reset button state.
   // TODO(varkha) While in drag only reset the state with Material Design.
   // The same logic may applies everywhere so gather any feedback and update.
   bool reset_button_state =
       !InDrag() || ui::MaterialDesignController::IsModeMaterial();
   if (state_ != STATE_DISABLED && reset_button_state)
@@ skipping 258 matching lines @@
   Button::NotifyClick(event);
 }
 
 void CustomButton::OnClickCanceled(const ui::Event& event) {
   AnimateInkDrop(views::InkDropState::HIDDEN,
                  ui::LocatedEvent::FromIfValid(&event));
   Button::OnClickCanceled(event);
 }
 
 }  // namespace views