Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 217813008: Use skia warmup for DirectWrite (Closed)

Created:
6 years, 9 months ago by scottmg
Modified:
6 years, 8 months ago
Reviewers:
jamesr, jschuh
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Use skia warmup for DirectWrite Skia after r14000 allows specifying the IDWriteFactory explicitly. Plumb that through to Blink with https://codereview.chromium.org/213223003/ and then switch the factory to isolated mode. R=jschuh@chromium.org TBR=jamesr@chromium.org BUG=333029 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261290

Patch Set 1 #

Patch Set 2 : add new factory function to blink and use it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -31 lines) Patch
M content/renderer/renderer_main_platform_delegate_win.cc View 1 2 chunks +15 lines, -31 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
scottmg
6 years, 8 months ago (2014-04-02 02:52:37 UTC) #1
jschuh
lgtm
6 years, 8 months ago (2014-04-02 03:33:52 UTC) #2
scottmg
blink roll is https://codereview.chromium.org/222773002/
6 years, 8 months ago (2014-04-02 19:48:54 UTC) #3
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 8 months ago (2014-04-03 00:14:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/217813008/20001
6 years, 8 months ago (2014-04-03 00:18:20 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 00:52:27 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=59197
6 years, 8 months ago (2014-04-03 00:52:27 UTC) #7
scottmg
tbr jamesr for owners
6 years, 8 months ago (2014-04-03 02:32:11 UTC) #8
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 8 months ago (2014-04-03 02:32:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/217813008/20001
6 years, 8 months ago (2014-04-03 02:35:30 UTC) #10
scottmg
6 years, 8 months ago (2014-04-03 07:05:46 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 manually as r261290 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698