Pass the /safeseh option to ml.exe.

test/win/gyptest-ml-safeseh.py

Index: test/win/gyptest-ml-safeseh.py
diff --git a/test/win/gyptest-ml-safeseh.py b/test/win/gyptest-ml-safeseh.py
new file mode 100644
index 0000000000000000000000000000000000000000..ec702b9df2f5fbc7b98dd9d73a4175c8f4ec1d60
--- /dev/null
+++ b/test/win/gyptest-ml-safeseh.py
@@ -0,0 +1,22 @@
+#!/usr/bin/env python
+
+# Copyright (c) 2014 Google Inc. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""
+Make sure the /safeseh option can be passed to ml.

[wtc, 2014/04/10 02:42:00]

Do I need to add this test (gyptest-ml-safeseh.py) to some file?

[scottmg, 2014/04/10 03:31:51]

No, they're globbed.

+"""
+
+import TestGyp
+
+import sys
+
+if sys.platform == 'win32':

[wtc, 2014/04/10 02:42:00]

This test is only applicable to 32-bit x86 (ia32) builds. How do I disable it
for 64-bit x64 builds?

+  test = TestGyp.TestGyp(formats=['ninja'])

[wtc, 2014/04/10 02:42:00]

Although I removed 'msvs' from this line, gyptest.py still tries to run with the
'msvs' format, and reports "No result from the following test" at the end. Do
you know how to fix this?

D:\src\chrome6\src\tools\gyp>python gyptest.py test\win\gyptest-ml-safeseh.py
PYTHONPATH=D:\src\chrome6\src\tools\gyp\test\lib
TESTGYP_FORMAT=msvs
C:\python_27_amd64\files\python.exe test\win\gyptest-ml-safeseh.py
Invalid test for 'msvs' format; skipping test.
NO RESULT
TESTGYP_FORMAT=ninja
C:\python_27_amd64\files\python.exe test\win\gyptest-ml-safeseh.py
PASSED

No result from the following test:
        test\win\gyptest-ml-safeseh.py

[scottmg, 2014/04/10 03:31:51]

That's as expected.
It would be ideal to also add support to generator/msvs.py and make the test run
on both platforms.

(I'm not exactly sure how to do that, it's probably adding a few lines to
pylib/gyp/MSVSSettings.py but it doesn't have to be in this patch if it's not
obvious.)

[wtc, 2014/04/10 18:21:48]

I took a quick look at generator/msvs.py. It doesn't even handle source files
with the .asm extension:

def _MapFileToMsBuildSourceType(source, extension_to_rule_name):
  """...
  """
  _, ext = os.path.splitext(source)
  if ext in extension_to_rule_name:
    group = 'rule'
    element = extension_to_rule_name[ext]
  elif ext in ['.cc', '.cpp', '.c', '.cxx']:
    group = 'compile'
    element = 'ClCompile'
  elif ext in ['.h', '.hxx']:
    group = 'include'
    element = 'ClInclude'
  elif ext == '.rc':
    group = 'resource'
    element = 'ResourceCompile'
  elif ext == '.idl':
    group = 'midl'
    element = 'Midl'
  else:
    group = 'none'
    element = 'None'
  return (group, element)

So I'd prefer to *not* add .asm and MASM support to generator/msvs.py in this
CL.

Note: One reason I only worked on the ninja generator is that the Chromium build
instructions page
(http://www.chromium.org/developers/how-tos/build-instructions-windows) only
mentions the use of ninja at the top, and all the old contents that mention msvs
are now marked as deprecated or untested. Did you suggest that I add msvs
support because GYP is also used by non-Chromium projects?

[scottmg, 2014/04/10 19:23:22]

Yes, Chromium only uses ninja now, but we have historically tried to keep
msvs.py and ninja.py feature support in gyp as close as possible.

I think .asm files are supported somehow in msvs, but I don't know how. I think
it's fine to let someone else fix this up if they run into it.

+
+  CHDIR = 'ml-safeseh'
+  test.run_gyp('ml-safeseh.gyp', chdir=CHDIR)
+  test.build('ml-safeseh.gyp', test.ALL, chdir=CHDIR)
+
+  test.pass_test()