Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: test/win/ml-safeseh/ml-safeseh.gyp

Issue 217813007: Pass the /safeseh option to ml.exe. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Add a unit test gyptest-ml-safeseh.py Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/win/gyptest-ml-safeseh.py ('K') | « test/win/ml-safeseh/hello.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/win/ml-safeseh/ml-safeseh.gyp
diff --git a/test/win/compiler-flags/pdbname.gyp b/test/win/ml-safeseh/ml-safeseh.gyp
similarity index 55%
copy from test/win/compiler-flags/pdbname.gyp
copy to test/win/ml-safeseh/ml-safeseh.gyp
index 8fcf754727c228ca363841d07ae84100a1c9ae6f..cae986b0377df61aaacb951577c6e61cdbbf6d09 100644
--- a/test/win/compiler-flags/pdbname.gyp
+++ b/test/win/ml-safeseh/ml-safeseh.gyp
@@ -1,22 +1,24 @@
-# Copyright (c) 2012 Google Inc. All rights reserved.
+# Copyright (c) 2014 Google Inc. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
{
'targets': [
{
- 'target_name': 'test_pdbname',
+ 'target_name': 'ml_safeseh',
'type': 'executable',
'sources': [
'hello.cc',
- 'pdbname.cc',
+ 'a.asm',
],
'msvs_settings': {
- 'VCCLCompilerTool': {
- 'DebugInformationFormat': '3',
- },
'VCLinkerTool': {
- 'GenerateDebugInformation': 'true',
+ 'AdditionalOptions': [
+ '/SAFESEH'
wtc 2014/04/10 02:42:00 Is there a setting I can use instead of adding '/S
scottmg 2014/04/10 03:31:51 It should be 'ImageHasSafeExceptionHandlers': 'tru
wtc 2014/04/10 18:21:48 Done. Thanks for the hint.
+ ]
+ },
+ 'MASM': {
+ 'UseSafeExceptionHandlers': 'true',
},
},
},
« test/win/gyptest-ml-safeseh.py ('K') | « test/win/ml-safeseh/hello.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698