Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2178073006: Disable Quick View by default and add about flag to enable it. (Closed)

Created:
4 years, 4 months ago by oka
Modified:
4 years, 4 months ago
Reviewers:
rkaplow, fukino
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Disable Quick View by default and add about flag to enable it. Set --enable-files-quick-view to enable quick view. BUG=613465 TEST=manually using link. TBR=fukino@chromium.org,rkaplow@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2127853002 Cr-Commit-Position: refs/heads/master@{#404617} (cherry picked from commit 0a9c9cdd253d3b0963b7676166bd612cdab7838a)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 2 chunks +4 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178073006/1
4 years, 4 months ago (2016-07-26 07:26:55 UTC) #2
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 4 months ago (2016-07-26 07:26:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178073006/1
4 years, 4 months ago (2016-07-26 07:29:49 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 07:32:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698